CE Phoenix Cart Forum

[cristiangliga]

Hello,

I'm getting the following error on Phoenix 1.0.8.14:

On page:

mywebsite/admin/orders.php

I get this error:

Notice: Trying to get property 'delivery' of non-object in mywebsite/includes/hooks/admin/orders/deliveryLink.php on line 31

Please take a look.

Thank you.

[raiwa]

Is this a virtual order without shipping address?

[raiwa]

O.K. I could reproduce this for virtual orders and if not any order is in the list.
To fix it, wrap in the hook the whole function code with the following check in line 27:

Code: Select all

    if (!empty($order->delivery)) {

So the whole function looks like:

Code: Select all

  function listen_injectSiteEnd() {
    global $order;

    if (!empty($order->delivery)) {
      $current_version = Versions::get('Phoenix');

      $replace_array = [',', 'Nº','C/','c/', 'nº', 'planta', 'piso', 'dcha.', 'izqa', 'Dcha', 'Izda', 'Izq','izq', 'º', 'ª'];

      $google_address = str_replace($replace_array, ' ', $order->delivery['street_address']) . ', ' . $order->delivery['city'] . ', ' . $order->delivery['postcode'] . ', ' . $order->delivery['state'] . ', ' . $order->delivery['country']['title'];
      if ($current_version > '1.0.8.0') {
        $google_button = '<a target="_blank" href="https://www.google.es/maps/place/' . $google_address . '">' . new Button(HOOK_DELIVERY_LINK_BUTTON_GOOGLE_MAPS, 'fas fa-search', 'btn-light') . '</a>';
      } elseif ($current_version > '1.0.3.0') {
        $google_button = '<a target="_blank" href="https://www.google.es/maps/place/' . $google_address . '">' . tep_draw_bootstrap_button(HOOK_DELIVERY_LINK_BUTTON_GOOGLE_MAPS, 'fas fa-search', '', '', [], 'btn-light') . '</a>';
      }

      $output = <<<EOD
  <script>
  $(function() {
  $('#orderTabs #section_summary_content table tbody:eq(0) tr td:nth-child(2)').append('{$google_button}');
  });
  </script>
  EOD;

      return $output;
    }
  }

Please confirm and I'll upload the update with this.

[cristiangliga]

Thank you very much, @raiwa! The error dissapears after wrapping the content of the function with the "if" condition (check).

However, none of the orders are virtual and they all have a shipping address. The error showed not only on the admin/orders.php link (page), but also on the admin/orders.php?oID=1, when an order was actually selected. When clicking on Edit or Delete and the orders.php had an action, for example on admin/orders.php?oID=1&action=edit, the error wasn't showing.

Thank you again for the solution!

Best regards,
Cristian