KissIT Image Thumbnailer

Shiny Red Apples - KissIT Image Thumbnailer

Shiny Red Apples

by MyGamesShop » Thu Sep 15, 2022 6:16 am

Gidday Rawia.

I had a small issue on the product page with the review section after installing Kissit on v1.0.8.18

<div class="row">
<div class="col-sm-6"><blockquote class="blockquote"><img class="float-left img-fluid" loading="lazy" src="pub/" border="0" title="" /><p class="font-weight-lighter">Lovely box of crunchy apples and delivered very quickly. Thank You!</p><footer class="blockquote-footer">Rated <span class="text-warning" title="5"><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i></span> by <cite title="John Doe">John Doe</cite></footer></blockquote></div> </div>
</div>

Gives a broken image before the Review.
Setting Image Required to False produced the correct code.

<div class="row">
<div class="col-sm-6"><blockquote class="blockquote"><p class="font-weight-lighter">Lovely box of crunchy apples and delivered very quickly. Thank You!</p><footer class="blockquote-footer">Rated <span class="text-warning" title="5"><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i><i class="fas fa-star"></i></span> by <cite title="John Doe">John Doe</cite></footer></blockquote></div> </div>
</div>

Just sayin thats all. (I disgraced myself elsewhere in the forums on this :( )
MyGamesShop
VIP Member
VIP Member
Posts: 49
Joined: Wed Mar 10, 2021 3:02 am
Contact:

Re: Shiny Red Apples

by raiwa » Thu Sep 15, 2022 1:57 pm

I don't see the relation to kissit thumbnail. If you have image required set to "true" the code in your module must take care that an image is always available.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 1184
Joined: Sat Dec 21, 2019 8:08 am
Contact:

Re: Shiny Red Apples

by MyGamesShop » Sun Sep 18, 2022 1:45 am

The point is that there is no image line at all in the stock code on this line but (And I'm guessing that no other plugin is changing this etc)
Kissit may be inserting/modifying it somehow and adding <img class="float-left img-fluid" loading="lazy" src="pub/" border="0" title="" />
It may be because of the review stars image immediately after it??
Any way give it a test and see if you can replicate, it may be peculiar to my server/setup.

5minutes later it might be the Base code.

in
admin/includes/actions/reviews/infoboxes/default.php
$contents[] = ['text' => $GLOBALS['Admin']->catalog_image($rInfo->products_image, [], $rInfo->products_name, SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT)];
in
admin/includes/actions/reviews/views/preview.php
<div class="col-sm-2 text-right"><?= $Admin->catalog_image('images/' . $rInfo->products_image ?? '', [], $rInfo->products_name ?? '', SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) ?></div>

as somesite.com/admin/reviews.php
shows IMAGE DOES NOT EXIST
which it should..

And another 5mins later.. (Error in base code reported)

admin/includes/actions/reviews/infoboxes/default.php should be
$contents[] = ['text' => $GLOBALS['Admin']->catalog_image('images/' . $rInfo->products_image, [], $rInfo->products_name, SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT)];

But still did not correct the issue.
MyGamesShop
VIP Member
VIP Member
Posts: 49
Joined: Wed Mar 10, 2021 3:02 am
Contact: