Language Search & Edit

PHP 7.3 Issues? - Language Search & Edit

PHP 7.3 Issues?

by bermuda » Thu Apr 08, 2021 12:46 pm

I noticed I am now getting these kind of entries for many functions

[08-Apr-2021 08:11:36 America/New_York] PHP Notice: Constant HEADING_TITLE already defined in /home/XXXXXX/public_html/admin/includes/languages/english/action_recorder.php on line 13

following by

[08-Apr-2021 08:11:36 America/New_York] PHP Notice: Array to string conversion in /home/XXXXXXX/public_html/admin/zipur_language_tool.php on line 294
bermuda
Posts: 29
Joined: Mon Mar 08, 2021 3:37 pm
Contact:

Re: PHP 7.3 Issues?

by zipurman » Thu Apr 08, 2021 5:09 pm

This has nothing to do with PHP 7.3? I use PHP 7.3 on most of my production servers and do not see these errors.
PHP Notice: Constant HEADING_TITLE already defined in /home/XXXXXX/public_html/admin/includes/languages/english/action_recorder.php on line 13
This would suggest that you have more than one language file that is being loaded using HEADING_TITLE as a constant. HEADING_TITLE normally only loads once per area, unless a mod also is using HEADING_TITLE? I tried editing the admin/includes/languages/english/action_recorder.php and did not get any errors. If you look at the admin/includes/languages/english/action_recorder.php, is HEADING_TITLE only mentioned once?
Array to string conversion
If you have a constant that is an array, this may cause this error. What language file were you editing and what was it's content?
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Contact:

Re: PHP 7.3 Issues?

by bermuda » Thu Apr 15, 2021 8:01 pm

All language files.

It shows at the top of your code as NOTICES
bermuda
Posts: 29
Joined: Mon Mar 08, 2021 3:37 pm
Contact:

Re: PHP 7.3 Issues?

by zipurman » Thu Apr 15, 2021 8:08 pm

There must be a language file that is being loaded that has that value that shouldn't. The HEADING_TITLE constant should only exist in the following files (screenshot)
Attachments
Screen Shot 2021-04-15 at 2.06.51 PM.png
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Contact:

Re: PHP 7.3 Issues?

by Kofod95 » Mon Apr 26, 2021 7:35 pm

I have the same problem as bermuda describes, both on a 1.0.7.12 (multi-language with a few addons) and a 1.0.8.2 (vanilla). They are only notices, so everything works, and it just takes som scrolling to use the tool, but I'm surprised they are not there at your server.
My 1.0.7.12 is online (Server OS: Linux 3.12.18-clouder0; PHP Version: 7.3.27 (Zend 3.3.27); HTTP Server: Apache),
and my 1.0.8.2 is a local Xampp (Server OS: WINNT; PHP Version: 7.4.13 (Zend 3.4.0); HTTP Server: Apache/2.4.46 (Win64) OpenSSL/1.1.1h PHP/7.4.13).
Just in case that information might be useful to you.

//Daniel
I'm not smart, but sometimes even a blind chicken can find a corn.
Here are a lot of corns: Phoenix user guide
User avatar
Kofod95
VIP Member
VIP Member
Posts: 605
Joined: Sat Feb 06, 2021 7:38 pm
Contact:

Re: PHP 7.3 Issues?

by zipurman » Mon Apr 26, 2021 8:31 pm

Just out of curiosity ... what search phrase are you entering? I am also running PHP 7.3.27 and I have all error logging on and I get no errors. Do you have multiple languages specified or just English?
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Contact:

Re: PHP 7.3 Issues?

by zipurman » Tue Apr 27, 2021 4:27 am

I was able to reproduce this issue. Working on a fix.
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Contact:

Re: PHP 7.3 Issues?

by zipurman » Tue Apr 27, 2021 4:42 am

Version 0.2.1 corrects this issue. It was related to error reporting. If you had notices being shown on screen, then this issue would have been visible. I have disabled Notice logging in the one area needed as constants must be loaded and compared to make this tool work.
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Contact:

Re: PHP 7.3 Issues?

by Kofod95 » Tue Apr 27, 2021 6:04 am

Perfect, thank you very much!
I'm looking forward to use it even more!
BTW - That was some quick and efficient support!

//Daniel
I'm not smart, but sometimes even a blind chicken can find a corn.
Here are a lot of corns: Phoenix user guide
User avatar
Kofod95
VIP Member
VIP Member
Posts: 605
Joined: Sat Feb 06, 2021 7:38 pm
Contact: