CE Phoenix Cart Forum

[Omar_one]

in: includes\system\override\name_based_urls.php
at the beginning of the get_category_name method about line 333:

Code: Select all

    Guarantor::ensure_global('category_tree');

so it should be:

Code: Select all

  function get_category_name(&$cID) {
    global $db;

    $full_cPath = $this->get_full_cPath($cID, $single_cID); // full cPath needed for uniformity
    Guarantor::ensure_global('category_tree');
    $cName = ((MODULE_NB_URLS_USE_SEO_TITLES === 'True' && !Text::is_empty($seo_title = $GLOBALS['category_tree']->get($single_cID, 'seo_title')))

thank you so much Rainer,
on the 1st change I just add

Code: Select all

Guarantor::ensure_global('category_tree');

after

Code: Select all

$full_cPath = $this->get_full_cPath($cID, $single_cID);

as the function looking different
here is the whole function

Code: Select all

 function get_category_name(&$cID) {
    global $db;

    $full_cPath = $this->get_full_cPath($cID, $single_cID); // full cPath needed for uniformity
    $cName = ((MODULE_NB_URLS_USE_SEO_TITLES == 'True' && !Text::is_empty($GLOBALS['category_tree']->get($single_cID, 'seo_title')))? $GLOBALS['category_tree']->get($single_cID, 'seo_title') : $GLOBALS['category_tree']->get($single_cID, 'name'));
  $cName = $this->strip($cName);
  $return = $cName;
    $cID = $full_cPath;
    return $return;
  } # end function

[raiwa]

I do not see the difference.
Just put it after this line:

Code: Select all

$full_cPath = $this->get_full_cPath($cID, $single_cID);

[Omar_one]

on this line
here is from your post

Code: Select all

 $cName = ((MODULE_NB_URLS_USE_SEO_TITLES === 'True' && !Text::is_empty($seo_title = $GLOBALS['category_tree']->get($single_cID, 'seo_title')))

and here is from the module

Code: Select all

$cName = ((MODULE_NB_URLS_USE_SEO_TITLES == 'True' && !Text::is_empty($GLOBALS['category_tree']->get($single_cID, 'seo_title')))? $GLOBALS['category_tree']->get($single_cID, 'seo_title') : $GLOBALS['category_tree']->get($single_cID, 'name'));

I have the lite version

[Omar_one]

Thank you Rainer, some of errors not shown ,, but still those ones

Code: Select all

PHP Notice:  Undefined index: path in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 590
PHP Notice:  Undefined index: path in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 626
PHP Notice:  Undefined index: path in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 682
PHP Notice:  Undefined index: path in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 686
PHP Notice:  Undefined index: path in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 716

[raiwa]

I d o not get these in my test-shop and these are only notices.
But you could try changing line 589 and 625 to:

Code: Select all

    if (isset($this->attributes['SEO_REDIRECT']['URI_PARSED']['path']) && strpos($this->attributes['SEO_REDIRECT']['URI_PARSED']['path'], '.html') !== FALSE) {

Then line 681 to:

Code: Select all

      case ( isset($this->uri_parsed['path']) && !is_numeric(strpos(($this->uri), '{')) && strpos($this->uri_parsed['path'], "-p-") !== FALSE ):

And line 684 to:

Code: Select all

      case (  isset($this->uri_parsed['path']) && $this->uri != $this->real_uri && Text::is_empty($this->path_info)):

And line 715 to:

Code: Select all

        } else if ( isset($this->uri_parsed['path']) && ($pStart = strpos($this->uri_parsed['path'], "-c-")) !== FALSE ) {

Please report back

[Omar_one]

thank you Rainer I just tried to visit the shop different pages and there is no error ,, I will check the error_log file tomorrow when more customer visit the shop and I will let you know if the error appears ,, but till now there is no errors

thank you
Omar

[Omar_one]

Code: Select all

PHP Notice:  Undefined offset: 3 in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 814
PHP Notice:  Undefined offset: 1 in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 834
PHP Notice:  Undefined offset: 1 in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 834
PHP Notice:  Undefined offset: 1 in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 834
PHP Notice:  Undefined offset: 1 in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 834

lines 809 - 821

Code: Select all

  function parse_path($path_info) {
    $tmp = @explode('/', $path_info);
    if ( count($tmp) > 2 ) {
      $container = [];
      for ($i=0, $n=count($tmp); $i<$n; $i++) {
        $container[] = $tmp[$i] . '=' . $tmp[$i+1];
        $i++;
      }
      return @implode('&', $container);
    } else {
      return @implode('=', $tmp);
    }
  } # end function parse_path

lines 828-835

Code: Select all

 function do_redirect() {

    $p = @explode('&', $this->uri_parsed['query']);
    $params =  [];
    foreach( $p as $index => $value ){
      $tmp = @explode('=', $value);
      $params[$tmp[0]] = $tmp[1];
    }

maybe it's need something like this

Code: Select all

$tmp= [];

or

Code: Select all

$tmp= array();

[raiwa]

This would fix:
"undefined variable $tmp....."

[Omar_one]

new PHP Notice

Code: Select all

PHP Notice:  Trying to access array offset on value of type null in /home/XXXX/public_html/includes/system/override/name_based_urls.php on line 367
PHP Notice:  Undefined index: manufacturers_name in /home/XXXX/public_html/includes/classes/manufacturer.php on line 26
PHP Notice:  Undefined index: manufacturers_image in /home/XXXX/public_html/includes/classes/manufacturer.php on line 26
PHP Notice:  Undefined index: manufacturers_description in /home/XXXX/public_html/includes/classes/manufacturer.php on line 26

Lines 353-370

Code: Select all

  function get_manufacturer_name($mID) {

    $sqlCmd = MODULE_NB_URLS_USE_SEO_TITLES == 'True' ? 'IF(md.manufacturers_seo_title != "", md.manufacturers_seo_title, m.manufacturers_name) as mName' : 'm.manufacturers_name as mName';
    $sql = sprintf(<<<'EOSQL'
SELECT %s
  FROM manufacturers m
  LEFT JOIN manufacturers_info md
    ON m.manufacturers_id = md.manufacturers_id
  WHERE m.manufacturers_id = %s
    LIMIT 1
EOSQL
        , $sqlCmd, (int)$mID);

    $result = $GLOBALS['db']->query($sql)->fetch_assoc();
    $mName = $this->strip( $result['mName'] );
    $return = $mName;
    return $return;
  } # end function
 

[raiwa]

IN line 367 try:

Code: Select all

       $mName = $this->strip( $result['mName']?? '' );