1.1.0.7 Questions / Comments / Concerns / Feedback

[raiwa]

or maybe in admin/products_attributes.php line 63:

Code: Select all

    $grouped_values[] = ['id' => $value['id'], 'text' => $value['text'], 'parameters' => ['data-id' => $value['products_options_id']?? '']];

[burt]

I don't think it's a good idea to `hide` an error message.
It's the data that is incomplete so that should give an error message,

[ecartz]

Could change the error message.

Code: Select all

        if (isset($option['parameters']) && is_array($option['parameters'])) {
          foreach ($option['parameters'] as $name => $value) {
            if (isset($value)) {
              $field .= sprintf(' %s="%s"', $name, Text::output($value, static::ESCAPES));
            } else {
              trigger_error("No value for [$name]");
            }
          }
        }

If the problem is that it doesn't show where the problem is.

Or write a security check that looks for missing attribute (value?) names. Which could show *exactly* where the problem is.

[Blaine]

I do have a question on the zip file, it has an install/ directory with a sql file in it that would seem to erase everything. Why would that be included in a update only file?

[burt]

I do have a question on the zip file, it has an install/ directory with a sql file in it that would seem to erase everything. Why would that be included in a update only file?

We have users who are not shopowners, and these people need to keep the whole file-set updated.
If a shopowner follows update instructions intently, the imagined scenario cannot happen.

The inclusion is a deliberate trade‑off; convenience for users (including non-shopowners) vs. a risk that is fully neutralized by following two simple, clearly documented steps. The assumption is that anyone running a live store will take those basic security measures as a matter of course.

[azpro]

Thought I mention the admin demo is not yet updated to 1.1.0.7 - https://phoenixcart.org/demo_admin/admin/index.php

Forgotten or lack of time?

[burt]

lack of time

Yes, unfortunately.

I have no idea how to devote more time without giving up the time that pays bills, or giving up my downtime.

[azpro]

lack of time

Yes, unfortunately.

I have no idea how to devote more time without giving up the time that pays bills.

I understand - if only I could help .. but probably updating is something you would like to do yourself ..

[burt]

It would be difficult as it would involve (non standard) Hosting Control Panel access etc.
There is a lot of things in there.

But TY for offering, I appreciate it.

Here is a similar thread viewtopic.php?f=43&t=3406 (you're already in there TY, but most users of this forum are not).

[tessthepup]

@burt
Not sure if it is me but I have upgraded the demo site https://phoenix-demo.co.uk/ from 1.1.0.6 to 1.1.0.7 and the only issue I have is the loss of half of the admin hMenu.

Has this happened to anyone else?

After restoring the 1.1.0.6 version it works fine