Just enquiring why a small bit of code in admin/modules.php was changed

[14Steve14]

This is probably one for @burt or @ecartz

I am updating my current site to the latest 1.1.0.7, not yet updated to 1.1.0.8, version, and in testing we noticed that on the modules page in admin when viewing the content section the dropdown list was missing. Just wondering if this was intentional as there was a problem with the code, or whether it was just an oversight.

The bit of code in question is around lines 126-126 and originally is

Code: Select all

<?php
  $cfgm = "uncallable_cfgm_$set";
  if (is_callable([$cfgm, 'menu'])) {
?>

When a simple change back to the same as was in the older versions the dropdown selection list shows

Code: Select all

<?php
  $cfgm = "cfgm_$set";
  if (is_callable([$cfgm, 'menu'])) {
?>

[BrockleyJohn]

I think that change was released in 1.0.9.6
https://github.com/CE-PhoenixCart/Phoen ... 60488b6ff9

[burt]

Intentional (as a quick sticking plaster) to remove a menu which was causing issues.