v1.0.8.0 Questions / Comments / Concerns

Open to all! Ask other shopowners for help.
User avatar
Pierre_P
Contributor
Posts: 144
Joined: Fri Mar 12, 2021 5:06 am
Phoenix Version: v1.1.0.6
Has thanked: 21 times
Been thanked: 11 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by Pierre_P »

Language file administrators_WG.php missing?

Tags:


Join The Code Co-op to get access to your library in the Code Co-op Forum
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by ecartz »

Pierre_P wrote: Fri Mar 19, 2021 6:48 pm Language file administrators_WG.php missing?
There is no core file named administrators_WG.php

Add-on?
User avatar
Pierre_P
Contributor
Posts: 144
Joined: Fri Mar 12, 2021 5:06 am
Phoenix Version: v1.1.0.6
Has thanked: 21 times
Been thanked: 11 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by Pierre_P »

addon it was
raiwa
Certified Developer
Posts: 1640
Joined: Sat Dec 21, 2019 8:08 am
Phoenix Version: 1.1.0.6
Has thanked: 70 times
Been thanked: 152 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by raiwa »

If I well remember, the name of the main file doesn’t match the names of the language files. Change to be all lower case.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
Nigel
Contributor
Posts: 114
Joined: Mon Jan 11, 2021 1:39 am
Phoenix Version:
Has thanked: 29 times
Been thanked: 8 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by Nigel »

The Buy Button and Objects & Attribute Content Modules are available for product_info but are also present as standard.
The pic shows two instances of each.

prod_info_x2.png
You do not have the required permissions to view the files attached to this post.
User avatar
zipurman
Builder
Posts: 540
Joined: Tue Oct 13, 2020 5:20 pm
Phoenix Version: v
Has thanked: 93 times
Been thanked: 162 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by zipurman »

That means that you have both the buy buttons turned on as a Product Info Module as well as a PI Module.

One is in the Admin -Modules - Content - (labeled as product_info) (Options & Attributes / Buy Button)

On is in the Admin - Product Info - (Options & Attributes / Buy Button)
zipurman
-----------
Nigel
Contributor
Posts: 114
Joined: Mon Jan 11, 2021 1:39 am
Phoenix Version:
Has thanked: 29 times
Been thanked: 8 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by Nigel »

zipurman wrote: Thu Mar 25, 2021 12:16 am That means that you have both the buy buttons turned on as a Product Info Module as well as a PI Module.

One is in the Admin -Modules - Content - (labeled as product_info) (Options & Attributes / Buy Button)

On is in the Admin - Product Info - (Options & Attributes / Buy Button)

So not really as standard but duplicate from another option I'd already used.
The same with "model" too.

I saw them in the Content option and wondered if they were the same and tested it to confirm.
Do we need this option available from two different locations ?

Thanks for the reply.
User avatar
zipurman
Builder
Posts: 540
Joined: Tue Oct 13, 2020 5:20 pm
Phoenix Version: v
Has thanked: 93 times
Been thanked: 162 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by zipurman »

The PI or Product Info modules give more control over placement. The PI or π module needs to be installed into Content Modules, and then you can go to Admin - Product Info to configure them. The other duplicate modules can be disabled in Admin - Content - product_info items as they pre-date PI.
zipurman
-----------
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: v1.0.8.0 Questions / Comments / Concerns

Post by ecartz »

Nigel wrote: Thu Mar 25, 2021 12:24 am Do we need this option available from two different locations ?
I don't know. Some questions that would need answering to determine this:

1. Can you match the display of the content modules with the PI modules in all circumstances? I'm inclined to believe that you can't, but I do not know that for sure.
2. How many store owners use the content module version?
3. How many store owners use the PI version?
4. Why? (Possibly #1 or possibly something else.)

These aren't technical questions but business questions. If you can demonstrate that having the two options does not add flexibility that store owners value, we could remove the content modules. But until someone goes through the work to do that, this isn't something that we are likely to prioritize.

1. It's possible that having both is necessary.
2. We have to support some content modules regardless, as they are used on other pages that don't have PI modules.
3. PI modules are more powerful in layout terms than content modules. So we aren't going to remove them.
4. If you don't want to use one or the other, you don't have to do so. Neither is imposed upon you.

Overall, we will tend to focus on increasing flexibility rather than reducing it. I don't know that keeping the product_info content modules is necessary. But I don't know that it's not. As such, it is easier to let individual store owners make that determination.

If we did remove those content modules, the goal would likely be to reduce our maintenance overhead. But even there, I don't see these as the leading edge. I would be more likely to remove Who's Online and Open Search as two things that we aren't really using that could be add-ons instead.
WP Horlogebanden
Member
Posts: 8
Joined: Thu Mar 25, 2021 7:35 pm
Phoenix Version:
Has thanked: 1 time

Re: v1.0.8.0 Questions / Comments / Concerns

Post by WP Horlogebanden »

Hello,
I just updated from 1.0.7.15 to 1.0.8.0 (via 1.0.7.16). I noticed some changes, which I may have overlooked in the past. I am messing with core code, so: my fault. I do have an operational site despite my messing with the core. The comparison between 1.0.7.16 (via 1.0.7.18 to 1.0.8.0) shows 1 more file than update.zip.

To be completely sure I am back on track with all previous changes, I downloaded from phoenixcart.org the new release. I noticed that install\phoenix.sql is incorrect as Cote D'Ivore messes up de sql. In the new github, I see this has already been solved. It would be nice however for any new users that installation does not fail, due to this error. Please update the installaton a.s.a.p. (which is "as soon as possible for you", off course).


Join The Code Co-op to get access to your library in the Code Co-op Forum
Post Reply