Country dropdown menu is a mess

[ReneH4]

After more than 10 years of usage my country table has become a bit messy.

As a result the dropdown menu in create_account is no longer an alphabetical list.

It shows the countries in order of countries_id.

I would like to fix that and have the list sorted by countries_name.

Anyone has done that?

[burt]

Which v Phoenix (or Frozen, Gold, etc) ?

[ReneH4]

Sure, forgot to mention: 1079 Phoenix

Good to see you back Gary!

Which v Phoenix (or Frozen, Gold, etc) ?

[burt]

The simplest solution would probably be to add an order by clause in the relevant module;

https://github.com/CE-PhoenixCart/Phoen ... y.php#L184

Should be enough to get you going?

[ecartz]

I would think it would be even simpler to just rebuild the table in the proper order.

I'm pretty sure that it sorts in insertion order, not by ID (it's just that the IDs are also in insertion order). So just export the table (including the IDs), reorder the insertion statements, drop the table, and import the table again.

That might be slightly more work upfront, but then you don't need to modify the code at all. And of course this doesn't limit you to ordering by country name. The order could be entirely arbitrary.

The advantage of not modifying the code is that you don't have to maintain the code going forward.

[ReneH4]

Will look at both options, thanks!

[ReneH4]

I took Gary's advice and changed core. Not that changing core would be Gary's advice :-)

Changed:

Code: Select all

$countries_query = tep_db_query("SELECT countries_id, countries_name FROM countries");

To:

Code: Select all

$countries_query = tep_db_query("SELECT countries_id, countries_name FROM countries ORDER BY countries_name ASC");

The simplest solution would probably be to add an order by clause in the relevant module;

https://github.com/CE-PhoenixCart/Phoen ... y.php#L184

Should be enough to get you going?

[ArtcoInc]

I would think it would be even simpler to just rebuild the table in the proper order.
...
The advantage of not modifying the code is that you don't have to maintain the code going forward.

Another advantage is that you can place your country of business at the top of the list. For example, I'm in the United States, and most of my customers are. So, it would make sense (to me, at least) to have the USA at the top of the list.

Malcolm

[Omar_one]

I would think it would be even simpler to just rebuild the table in the proper order.
...
The advantage of not modifying the code is that you don't have to maintain the code going forward.

Another advantage is that you can place your country of business at the top of the list. For example, I'm in the United States, and most of my customers are. So, it would make sense (to me, at least) to have the USA at the top of the list.

Malcolm

You can check @zipurman add-on Favorite Countries app.php/addons/free_addon/favorite_countries/

[ReneH4]

I installed this one too, nice to have!

You can check @zipurman add-on Favorite Countries app.php/addons/free_addon/favorite_countries/