1.0.8.21 Questions / Comments / Concerns

Open to all! Ask other shopowners for help.
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by heatherbell »

CGIFTER wrote: Mon Feb 19, 2024 11:15 am The breaking of "create_account.php"
create_account.php is not broken, just change the configurations as already described.

Tags:


Join The Code Co-op to get access to your library in the Code Co-op Forum
Scratchilito
Member
Posts: 37
Joined: Wed Jan 26, 2022 2:15 pm
Phoenix Version: v1.1.0.6
Has thanked: 6 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by Scratchilito »

Hello,
For me, create_account.php notifies an error on line 49. And I have a 2x6 display rather than a 12 display on my 1.0.8.20 online version.

Here is the old code for line 50 (on prod v20):

Code: Select all

foreach ($modules as $module) {
      $module->display_input($customer_details);
    }
And the new line 49 (in test v21):

Code: Select all

   <div class="<?= $customer_data_group['customer_data_groups_width'] ?>">
Concerning Localization>Customer Data Groups, are both the 6 form entries to be changed to col-sm-12 instead of 12? (I just did it without result).

The only Module/Header tags I found to uninstall was 'Datepicker jQuery', not 'ht Datepicker jQuery'
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by heatherbell »

Scratchilito wrote: Wed Feb 21, 2024 4:50 pmare both the 6 form entries to be changed to col-sm-12 instead of 12?
Already answered in previous post - viewtopic.php?p=15306#p15306
Ensure you have run SQL - https://github.com/CE-PhoenixCart/Updat ... update.sql
It is includes/modules/header_tags/ht_datepicker_jquery.php https://github.com/CE-PhoenixCart/Phoen ... jquery.php
User avatar
burt
Core Team
Posts: 4546
Joined: Tue Oct 29, 2019 9:37 am
Phoenix Version: v1.1.0.8
Has thanked: 252 times
Been thanked: 412 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by burt »

You can just change them to whatever, then looking at the create_account page to make sure you are happy with the layout. It should not be difficult.

If you have a 6 - 6 layout, then change to col-sm-6
If you have 8, change to col-sm-8
If you have 12, change to col-sm-12

Get used to it, because there will be a lot more of such changes in the future going from (eg) 9 to (eg) col-sm-9 and so on.
Scratchilito
Member
Posts: 37
Joined: Wed Jan 26, 2022 2:15 pm
Phoenix Version: v1.1.0.6
Has thanked: 6 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by Scratchilito »

Thanks for help.
heatherbell wrote: Wed Feb 21, 2024 5:14 pm
Scratchilito wrote: Wed Feb 21, 2024 4:50 pmare both the 6 form entries to be changed to col-sm-12 instead of 12?

Already answered in previous post - viewtopic.php?p=15306#p15306
Ok for all entries, I had seen the answer and my question was subsequently desired to understand having a doubt because I've never entered a value like this before. Thanks Burt for the confirmation and information.
heatherbell wrote: Wed Feb 21, 2024 5:14 pm Ensure you have run SQL - https://github.com/CE-PhoenixCart/Updat ... update.sql
Yes I did it.
heatherbell wrote: Wed Feb 21, 2024 5:14 pm It is includes/modules/header_tags/ht_datepicker_jquery.php https://github.com/CE-PhoenixCart/Phoen ... jquery.php
By cross-checking your instructions with the json or readme.md

Code: Select all

    "required_modules_remove": [
	"header_tags/ht_datepicker_jquery.php"
    ],
    "required_modules_install": [],
    "optional_modules_install": [],
    "optional_files_delete": [
    "includes/modules/header_tags/ht_datepicker_jquery.php",
	"includes/languages/english/modules/header_tags/ht_datepicker_jquery.php"
    ],
    "required_files_delete": []
  • I have updated mysql (phpmyadmin)
  • I've uninstalled the modules/header/datepicker_jquery
  • I deleted the ht_datepicker_jquery.php files (modules and languages)
The module/header/datepicker_jquery is well no longer available for installation.
  • I've set all the widths of the customers datas groups to col-sm-12
Unfortunately, I still get the error on line 49 of create_account.php which is repeated for each block (personal infos, address, contact, password) and the display changes between Firefox and Google chrome.
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by heatherbell »

Scratchilito wrote: Wed Feb 21, 2024 6:20 pm Unfortunately, I still get the error on line 49 of create_account.php which is repeated for each block (personal infos, address, contact, password) and the display changes between Firefox and Google chrome.
Post the error
Scratchilito
Member
Posts: 37
Joined: Wed Jan 26, 2022 2:15 pm
Phoenix Version: v1.1.0.6
Has thanked: 6 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by Scratchilito »

No further information other than on :

Firefox:
Image

and

Chrome:
Image
User avatar
bonbec
Contributor
Posts: 190
Joined: Mon Oct 26, 2020 12:23 pm
Phoenix Version: V1.1.0.7
Has thanked: 54 times
Been thanked: 40 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by bonbec »

Hello,
Remove the "> at the end of the line 49 in template/default/includes/pages/create_account.php
I have this too in my 1.0.8.21 full version

Bonjour, un autre français, c'est cool ;-)
Retire "> à la fin de la ligne 49 dans template/default/includes/pages/create_account.php
J'ai çà aussi dans ma version 1.0.8.21 complète.

Fred (France)
Old MS2.2 PHP7.4 site being converted to CE Phoenix v1.1.0.6 PHP 8.3
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by ecartz »

bonbec wrote: Thu Feb 22, 2024 6:28 am Remove the "> at the end of the line 49 in template/default/includes/pages/create_account.php
That is not the correct fix. The correct fix would be to remove "> from the width in the database. The "> at the end of that line should be there.
User avatar
burt
Core Team
Posts: 4546
Joined: Tue Oct 29, 2019 9:37 am
Phoenix Version: v1.1.0.8
Has thanked: 252 times
Been thanked: 412 times

Re: 1.0.8.21 Questions / Comments / Concerns

Post by burt »

bonbec wrote: Thu Feb 22, 2024 6:28 am Hello,
Remove the "> at the end of the line 49 in template/default/includes/pages/create_account.php
I have this too in my 1.0.8.21 full version

Bonjour, un autre français, c'est cool ;-)
Retire "> à la fin de la ligne 49 dans template/default/includes/pages/create_account.php
J'ai çà aussi dans ma version 1.0.8.21 complète.
https://github.com/CE-PhoenixCart/Phoen ... nt.php#L49

is correct.

No to remove the HTML "> please
The extra "> is coming from somewhere else, not L49.
Ne supprimez pas le code HTML "> de cette ligne 49.
Le code HTML "> supplémentaire vient d'ailleurs.


Join The Code Co-op to get access to your library in the Code Co-op Forum
Post Reply