Address Layout in Module

Open to all! Ask other shopowners for help.
Fiber
Contributor
Posts: 173
Joined: Mon Oct 26, 2020 12:16 pm
Phoenix Version: v1.1.0.6
Has thanked: 17 times
Been thanked: 27 times

Re: Bug Hunt!

Post by Fiber »

ecartz wrote: Wed Jun 12, 2024 11:48 am Change https://github.com/CE-PhoenixCart/Phoen ... 1-L144C137 to

Code: Select all

      $text = strip_tags(html_entity_decode(preg_replace("{<br[^>]*>\r?\n?}gi", $this->lf, $email_text), ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML5, $this->build_params['text_charset']));
Text emails strip out the br tags.
No luck still the same..strange
afterchangemailphp.png
You do not have the required permissions to view the files attached to this post.
Turn up the Max


Join The Code Co-op to get access to your library in the Code Co-op Forum
MyGamesShop
Contributor
Posts: 131
Joined: Wed Mar 10, 2021 3:02 am
Phoenix Version: v1.1.0.6
Has thanked: 8 times
Been thanked: 5 times

Re: Bug Hunt!

Post by MyGamesShop »

Not a bug.

Can we restore support for the .jpeg file extension.

Ta
User avatar
bonbec
Contributor
Posts: 190
Joined: Mon Oct 26, 2020 12:23 pm
Phoenix Version: V1.1.0.7
Has thanked: 54 times
Been thanked: 40 times

Re: Bug Hunt!

Post by bonbec »

Hello,
I don't know if it's a bug (version 1.0.9.1) or if it's normal. I want to bold some words in the category description. <b></b> tags cause a line break.
baliseB.jpg
You do not have the required permissions to view the files attached to this post.
Old MS2.2 PHP7.4 site being converted to CE Phoenix v1.1.0.6 PHP 8.3
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: Bug Hunt!

Post by heatherbell »

bonbec wrote: Wed Jun 19, 2024 4:37 pm I don't know if it's a bug (version 1.0.9.1) or if it's normal. I want to bold some words in the category description. <b></b> tags cause a line break.
It does not do that on a default clean install. Guess you have a style that is causing it, maybe something with display:block;
User avatar
bonbec
Contributor
Posts: 190
Joined: Mon Oct 26, 2020 12:23 pm
Phoenix Version: V1.1.0.7
Has thanked: 54 times
Been thanked: 40 times

Re: Bug Hunt!

Post by bonbec »

Thank you for your reply but it is the same in a fresh install (version 1.0.9.1). I also tested on a clean installation before posting my message.
Old MS2.2 PHP7.4 site being converted to CE Phoenix v1.1.0.6 PHP 8.3
User avatar
burt
Core Team
Posts: 4551
Joined: Tue Oct 29, 2019 9:37 am
Phoenix Version: v1.1.0.8
Has thanked: 252 times
Been thanked: 412 times

Re: 🐞 Bug Hunt! 🐞

Post by burt »

If not standard text in a card-body, it must be in a card-text container.
See https://getbootstrap.com/docs/4.6/compo ... rd/#images

In other words:

Code: Select all

<div class="card-text">
  abc <b>123</b> def
</div>
or

Code: Select all

<p class="card-text">
  abc <b>123</b> def
</p>
etc
I am not here to build for you.
I am here to build with you. Let's help each other.
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: Bug Hunt!

Post by heatherbell »

bonbec wrote: Thu Jun 20, 2024 9:29 am Thank you for your reply but it is the same in a fresh install (version 1.0.9.1). I also tested on a clean installation before posting my message.
Sorry, tested Product Description, not Category Description :roll:
User avatar
bonbec
Contributor
Posts: 190
Joined: Mon Oct 26, 2020 12:23 pm
Phoenix Version: V1.1.0.7
Has thanked: 54 times
Been thanked: 40 times

Re: Bug Hunt!

Post by bonbec »

burt wrote: Thu Jun 20, 2024 9:59 am...

Code: Select all

<p class="card-text">
  abc <b>123</b> def
</p>
...
Thank you @burt
I find that it is more intuitive and practical to write the text directly with the tags than to think about adding the code cited above.
So I placed the modified file in my template:
templates/MyTemplate/includes/modules/content/index_products/tpl_cm_ip_category_manufacturer_description.php
It work fine as I like.

@heatherbell No problem, I wasn't explicit enough in my message I think.
Old MS2.2 PHP7.4 site being converted to CE Phoenix v1.1.0.6 PHP 8.3
User avatar
bonbec
Contributor
Posts: 190
Joined: Mon Oct 26, 2020 12:23 pm
Phoenix Version: V1.1.0.7
Has thanked: 54 times
Been thanked: 40 times

ht_canonical.php

Post by bonbec »

Hello,
Not a bug but a space and a / to remove in includes/modules/header_tags/ht_canonical.php line 57 :

Code: Select all

      $GLOBALS['Template']->add_block('<link rel="canonical" href="' . $this->build_link() . '" />' . PHP_EOL, $this->group);
The generated line is :

Code: Select all

<link rel="canonical" href="http://localhost/1091/product_info.php?products_id=9" />
It must be :

Code: Select all

<link rel="canonical" href="http://localhost/1091/product_info.php?products_id=9">
Old MS2.2 PHP7.4 site being converted to CE Phoenix v1.1.0.6 PHP 8.3
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: ht_canonical.php

Post by ecartz »

bonbec wrote: Tue Jul 09, 2024 8:16 pm It must be :
According to whom?


Join The Code Co-op to get access to your library in the Code Co-op Forum
Post Reply