1.0.9.8 Questions / Comments / Concerns / Feedback
-
heatherbell
- Senior Contributor
- Posts: 2540
- Joined: Mon Oct 07, 2019 4:39 am
- Phoenix Version:
- Has thanked: 35 times
- Been thanked: 243 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
Input Comment and proceed to checkout_confirmation.
Customer decides to delete comment, click Edit goes back to checkout_payment as expected.
Delete Comment and proceed but Comment persists through checkout.
Seems impossible to delete Comment after initial input.
You do not have the required permissions to view the files attached to this post.
Tags:
- burt
- Core Team
- Posts: 4546
- Joined: Tue Oct 29, 2019 9:37 am
- Phoenix Version: v1.1.0.8
- : Buy Me A Beverage
- Has thanked: 252 times
- Been thanked: 412 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
I think this will take an architecture change;
- remove these comment input boxes from the checkout_payment and checkout_shipping.
- add comment input box on checkout_confirmation
- amend processing logic to catch _POST
Maybe Matt @ecartz has a less intrusive way.
Removing those input boxes from the two pages is probably a positive thing anyway.
- remove these comment input boxes from the checkout_payment and checkout_shipping.
- add comment input box on checkout_confirmation
- amend processing logic to catch _POST
Maybe Matt @ecartz has a less intrusive way.
Removing those input boxes from the two pages is probably a positive thing anyway.
I am not here to build for you.
I am here to build with you. Let's help each other.
I am here to build with you. Let's help each other.
-
heatherbell
- Senior Contributor
- Posts: 2540
- Joined: Mon Oct 07, 2019 4:39 am
- Phoenix Version:
- Has thanked: 35 times
- Been thanked: 243 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
Issue aside, think this is better than how it is handled now anyway. It also seems to be the most common way it is handled in most carts. The feature does not suit all store-owners so maybe good if it can be enabled/disabled.
-
frankl
- Builder
- Posts: 159
- Joined: Tue Feb 23, 2021 8:39 pm
- Phoenix Version: v1.1.0.4
- Has thanked: 17 times
- Been thanked: 25 times
Re: 1.0.9.9 uprated for accessibilty, seo and best practices. As well as speed of loading.
Excellent burt!
One small thing, could this line be changed in catalog/product_info.php
from:
to
which would stop counting views from spiders and only count views from real users.
If you don't want to change it, no biggie!
One small thing, could this line be changed in catalog/product_info.php
from:
Code: Select all
$db->query("UPDATE products_description SET products_viewed = products_viewed+1 WHERE products_id = " . (int)$_GET['products_id'] . " and language_id = " . (int)$_SESSION['languages_id']);Code: Select all
if (SESSION_BLOCK_SPIDERS == 'True') {
$db->query("UPDATE products_description SET products_viewed = products_viewed+1 WHERE products_id = " . (int)$_GET['products_id'] . " and language_id = " . (int)$_SESSION['languages_id']);
}If you don't want to change it, no biggie!
Check out my addons - app.php/addons/author/frankl/contributions
-
ecartz
- Core Team
- Posts: 3084
- Joined: Tue Nov 05, 2019 6:02 pm
- Phoenix Version:
- Has thanked: 4 times
- Been thanked: 208 times
Re: 1.0.9.9 uprated for accessibilty, seo and best practices. As well as speed of loading.
That's not what that would do. That would turn off view counting for both spiders and real users whenever it's set not to block spider sessions. It would do nothing when it is set to block spider sessions.
Code: Select all
if ($session_started) {- burt
- Core Team
- Posts: 4546
- Joined: Tue Oct 29, 2019 9:37 am
- Phoenix Version: v1.1.0.8
- : Buy Me A Beverage
- Has thanked: 252 times
- Been thanked: 412 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
I am not here to build for you.
I am here to build with you. Let's help each other.
I am here to build with you. Let's help each other.
-
14Steve14
- Senior Contributor
- Posts: 920
- Joined: Fri Oct 25, 2019 7:01 pm
- Phoenix Version: v1.0.9.1
- Has thanked: 17 times
- Been thanked: 103 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
We have a lot of customers leave things like 'Safe Place' delivery comments and other things such as leave with Neighbours and this seems the most logical place to leave that type of comments.burt wrote: ↑Tue Nov 12, 2024 1:15 pm I think this will take an architecture change;
- remove these comment input boxes from the checkout_payment and checkout_shipping.
- add comment input box on checkout_confirmation
- amend processing logic to catch _POST
Maybe Matt @ecartz has a less intrusive way.
Removing those input boxes from the two pages is probably a positive thing anyway.
We don't get that many comments relating to payments. Would it be easier to remove just one of the comments boxes.
After the order has been placed may be the wrong place and some customers would not expect to see such a box on that page. Most may never scroll down the page expecting to find it. I would never look for a box there. If I have a shipping comment it would always be left on the shipping page.
- burt
- Core Team
- Posts: 4546
- Joined: Tue Oct 29, 2019 9:37 am
- Phoenix Version: v1.1.0.8
- : Buy Me A Beverage
- Has thanked: 252 times
- Been thanked: 412 times
Re: 1.0.9.8 Questions / Comments / Concerns / Feedback
TY for feedback. It's been moved to the checkout_confirmation page to help mitigate a session problem.14Steve14 wrote: ↑Wed Nov 20, 2024 8:02 am We have a lot of customers leave things like 'Safe Place' delivery comments and other things such as leave with Neighbours and this seems the most logical place to leave that type of comments.
We don't get that many comments relating to payments. Would it be easier to remove just one of the comments boxes.
After the order has been placed may be the wrong place and some customers would not expect to see such a box on that page. Most may never scroll down the page expecting to find it. I would never look for a box there. If I have a shipping comment it would always be left on the shipping page.
I am not here to build for you.
I am here to build with you. Let's help each other.
I am here to build with you. Let's help each other.