1.0.9.9 Questions / Comments / Concerns / Feedback

[raiwa]

With the old core module the modal doesn't show and it trows the expected error:

Code: Select all

PHP Fatal error:  Uncaught Error: Undefined constant "PI_GALLERY_SWIPE_ARROWS" in C:\laragon\www\Raiwas_private_addons_8.2\templates\default\includes\hooks\shop\product_info\gallery.php:38

With your modified hook it works error free.
With my version it doesn't show modal, but no errors are logged.

I merged now your and my version:
- keeping your hook language file option as fallback for the case if the main pi gallery module is not installed
- removed support for the content module (it has its own complete code)
- all possible combinations are working error free
- no duplicated modal code is shown if the content module is used.

TestingRaiwa2.zip

[burt]

TY, I'll try to find time to load this change today or tomorrow.

[tessthepup]

Hi Guys,

I hope everyone is having a lovely xmas break and enjoying a bit of down time.

I have a fresh install of 1.0.9.9 but receiving this error

PHP Parse error: syntax error, unexpected end of file in /home/***/public_html/templates/bootstrap5/includes/hooks/shop/product_info/gallery.php on line 84

Has anyone else come across this?

Thanks

Mark

[ecartz]

I have a fresh install of 1.0.9.9 but receiving this error

Try adding a return at the end of the file.

[tessthepup]

I have a fresh install of 1.0.9.9 but receiving this error

Try adding a return at the end of the file.

@ecartz
Thank you. I tried that but it produces the same error

[ecartz]

I tried that but it produces the same error

Maybe https://github.com/CE-PhoenixCart/Phoen ... 452f8d1bfc

[tessthepup]

I tried that but it produces the same error

Maybe https://github.com/CE-PhoenixCart/Phoen ... 452f8d1bfc

@ecartz
well would you believe it lol that worked

Thank you

[rupruprup]

perhaps you should think about combining checkout shipping and checkout payment to one single page now ?

[bonbec]

perhaps you should think about combining checkout shipping and checkout payment to one single page now ?

In France, it's not allowed ...

[rupruprup]

Code: Select all

[07-Jan-2025 17:27:17 Europe/Berlin] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /templates/bootstrap5/includes/hooks/shop/product_info/gallery.php on line 17
[07-Jan-2025 17:27:17 Europe/Berlin] PHP Fatal error:  Uncaught Error: Undefined constant "PI_GALLERY_ALBUM_NAME" in /templates/bootstrap5/includes/hooks/shop/product_info/gallery.php:52
Stack trace:
#0 /includes/system/versioned/1.0.8.1/hooks.php(149): hook_shop_product_info_gallery->listen_injectBodyEnd(Array)
#1 /templates/bootstrap5/includes/components/template_bottom.php(57): hooks->cat('injectBodyEnd')
#2 /templates/default/includes/pages/product_info_not_found.php(21): require('...')
#3 /product_info.php(29): require('...')
#4 {main}
  thrown in /templates/bootstrap5/includes/hooks/shop/product_info/gallery.php on line 52

this happens on my installation if try to access a product thats does not exist anymore