Stripe V3 SCA

[mhsuffolk]

Test 1.0.8.0 shop on PHP 7.4 XAMPP
When installing Version 1.2.0 I get "This module has an unmet dependency. zone_id." and it does not install
I am using database from my 1.0.5.1 live store but with 1.0.8.0 configuration tables

[ecartz]

Test 1.0.8.0 shop on PHP 7.4 XAMPP
When installing Version 1.2.0 I get "This module has an unmet dependency. zone_id." and it does not install
I am using database from my 1.0.5.1 live store but with 1.0.8.0 configuration tables

Turn on the cd_state customer data module? Or something else that provides zone_id.

[mhsuffolk]

Turn on the cd_state customer data module? Or something else that provides zone_id.

Thank you, that has worked but I do not want to show the "State" box in the sign up pages, can I untick them all?

[raiwa]

@ecartz,
Would it have a side effect removing zone_id and the other, now optional, modules from the REQUIRES list?

Code: Select all

    const REQUIRES = [ 'name', 'email_address', 'id' ];

@mhsuffolk
if Matt agrees, you could modify line 18 in the module to above

[ecartz]

Would it have a side effect removing zone_id and the other, now optional, modules from the REQUIRES list?

Not if they're really optional now. I admit when I added them there, I didn't check if they were optional or not beyond looking at code like

Code: Select all

        $address = [
          'address_line1' => $order->billing['street_address'],
          'address_city' => tep_output_string($order->billing['city']),
          'address_zip' => tep_output_string($order->billing['postcode']),
          'address_state' => tep_output_string(tep_get_zone_name($order->billing['country_id'], $order->billing['zone_id'], $order->billing['state'])),
          'address_country' => tep_output_string($order->billing['country']['iso_code_2']),
        ];

Where it is clearly used regardless. If Stripe is happy without them, then there is nothing outside the module that will care whether the module uses them or not.

[raiwa]

This snippet has been changed in the latest version to:

Code: Select all

        $address = [
          'address_line1' => $GLOBALS['customer_data']->get('street_address', $order->billing),
          'address_city' => $GLOBALS['customer_data']->get('city', $order->billing),
          'address_zip' => $GLOBALS['customer_data']->get('postcode', $order->billing),
          'address_state' => $GLOBALS['customer_data']->get('state', $order->billing),
          'address_country' => $GLOBALS['customer_data']->get('country_iso_code_2', $order->billing),
        ];

        foreach ($address as $k => $v) {
            $content .= '<input type="hidden" id="' . Text::output($k) . '" value="' . Text::output($v ?? '') . '" />';
        }

And testing it without state module it doesn't throw errors. So I believe it should be save to remove them.

[raiwa]

I finally only removed state_id because the other modules are required in core checkout and it would need anyway more adjustments in core for not to use them.

Updated to Version: 1.2.1:
https://www.oscaddons.com/en/free-add-o ... -p-78.html

- Removed zone_id from the requires list to allow installation without state module.

[mhsuffolk]

Thanks @raiwa @ecartz, I discovered that once I got it installed I turned off the State field and Stripe still works perfectly.

[admin]

Support for this Addon will now be available on the Addon page - app.php/addons/free_addon/stripe_payment/support