heatherbell wrote: ↑Fri Feb 10, 2023 7:13 am
TYOP - Shows "Perdictive" in admin.
Superfluous/unexpected top padding/margin on every row except first row persists (as shown in previous post).
Yup ... fat fingers. Fixed the TYPOS for next release.
As for the extra space, there was some ... I removed it. It maybe your theme. If you have it installed, email me the link to the site and I can have a look at what CSS is creating the issue.
zipurman wrote: ↑Fri Feb 10, 2023 7:18 am
As for the extra space, there was some ... I removed it. It maybe your theme. If you have it installed, email me the link to the site and I can have a look at what CSS is creating the issue.
As seen in previous post, it is a clean demo site, no themes.
Space still persists - email sent.
heatherbell wrote: ↑Fri Feb 10, 2023 5:41 pm
As seen in previous post, it is a clean demo site, no themes.
Space still persists - email sent.
Yup. That is bottom margin to create space between results. It was removed and then re-added for narrow search results left/right. I have adjusted and sent you a file to test. Next release will remove it from wider fields as it stacks differently in narrow widths.
Updated from 1.2.0 to 1.3.0 Updated database via the message in admin. Search box stopped displaying typeahead. Had to uninstall via link in admin and then install again. Works fine now.
Possible Bug since 1.3.0 but it may have been there in 1.2.0, not sure.
In Who's Online, when a search is being typed in, an entry for each keystroke appears with /index.php in the "Last URL" column. So my site has had 20 identical rows.
FYI Predictive text is set to OFF as I think it muddies the water.
Martin
mhsuffolk wrote: ↑Sat Feb 11, 2023 8:46 am
Updated from 1.2.0 to 1.3.0 Updated database via the message in admin. Search box stopped displaying typeahead. Had to uninstall via link in admin and then install again. Works fine now.
When I added the option to turn predictive off, I defaulted it to off. I should have shown in your options list when you upgraded.
mhsuffolk wrote: ↑Sat Feb 11, 2023 12:29 pm
Possible Bug since 1.3.0 but it may have been there in 1.2.0, not sure.
In Who's Online, when a search is being typed in, an entry for each keystroke appears with /index.php in the "Last URL" column. So my site has had 20 identical rows.
FYI Predictive text is set to OFF as I think it muddies the water.
Martin
For every keystroke, it sends an ajax call to index.php that gets intercepted by the hook. I will look into what options there are to hide that from whois logging. @ecartz ... any ideas on a param that can be passed to ignore whois?
If you're properly passing the session ID with each request, it should only show one row. Subsequent letters should overwrite the same row. So that's where I'd start with debugging. Verify that the session ID is being passed properly rather than generating a new session each time. Session ID can be passed by GET parameter or by cookie.
Now, if you want to block whos_online from inserting at all at some time, you can replace the system hook ( _24_whos_online ) with one that checks whatever criteria before calling whos_online. I.e. just update that row in the database to point to your own method which says something like
Maybe an option to not start searching until a certain number of characters have been entered? E.g. Type Ahead would not be triggered until 3 characters are typed into the search box.
ecartz wrote: ↑Sat Feb 11, 2023 9:58 pm
If you're properly passing the session ID ...
Dumb question ... but what is the "proper" way to pass the session id? If you navigate between pages in Phoenix it doesn't register multiple entries into the whois database, and the session ID is not part of those urls? Also, I cannot replicate this, so not sure what session setup needs to be in place to have this issue occur? @mhsuffolk what version of Phoenix are you using?
