1.0.8.9 Questions / Comments / Concerns

Ask the community for help and support.
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

1.0.8.9 Questions / Comments / Concerns

Post by ecartz »

Update instructions (from 1.0.8.8): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.9

This is the 1.0.8.9 release, in the 1.0.8.* series. Primary changes:

1. Modernizes the files in includes/system, includes/classes, and includes/languages
2. Makes the row onclick optional in the paginated table component.

Tags:
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 1184
Joined: Sat Dec 21, 2019 8:08 am
Has thanked: 38 times
Been thanked: 102 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by raiwa »

account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
I didn't try on other places where "dob" is used, but may be the same.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
philpla
Posts: 27
Joined: Sun Feb 28, 2021 8:37 am
Has thanked: 2 times
Been thanked: 1 time

Re: 1.0.8.9 Questions / Comments / Concerns

Post by philpla »

a happy new year to everyone ... :)

thx for the new version 1.0.8.9 ... imho the following is wrong:

Code: Select all

includes/system/versioned/1.0.5.4/email.php line 45ff

    protected $html_images = [];
    protected $attachments = [];

Code: Select all

includes/system/versioned/1.0.5.4/email.php line 225f

      $attachments = !Text::is_empty($this->attachments);
      $html_images = !Text::is_empty($this->html_images);

Code: Select all

includes/system/versioned/1.0.8.2/text.php line 38
    public static function is_empty(string $s = null) {
this gives me a
PHP Fatal error: Uncaught TypeError: Argument 1 passed to Text::is_empty() must be of the type string or null, array given
Fiber
VIP Member
VIP Member
Posts: 121
Joined: Mon Oct 26, 2020 12:16 pm
Has thanked: 12 times
Been thanked: 19 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by Fiber »

raiwa wrote: Tue Dec 28, 2021 9:45 am account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
I didn't try on other places where "dob" is used, but may be the same.
Also in admin edit customer, dob still blanco..
Turn up the Max
ozeworks
PhoenixCart Developer
PhoenixCart Developer
Posts: 16
Joined: Tue Dec 21, 2021 2:58 pm
Has thanked: 5 times
Been thanked: 1 time

Re: 1.0.8.9 Questions / Comments / Concerns

Post by ozeworks »

I feel that this viewtopic.php?f=28&t=1102&p=7941#p7941 issue might be connected to this one. Both triggered by date of birth issues. Could be wrong ...
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 1184
Joined: Sat Dec 21, 2019 8:08 am
Has thanked: 38 times
Been thanked: 102 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by raiwa »

Code: Select all

        'MODULE_CONTENT_IN_CATEGORY_LISTING_DISPLAY_ROW' => [
          'title' => 'Categories Per Row',
          'value' => 'row row-cols-2 row-cols-sm-3 row-cols-md-4',
          'desc' => 'How many categories should display per Row per viewport?  Default:  XS 2, SM 3, MD and above 4',
        ],
shows vertical subcategory list.
To show horizontally it should be:

Code: Select all

          'value' => 'row cols-2 cols-sm-3 cols-md-4',
Same in the install script.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
Fiber
VIP Member
VIP Member
Posts: 121
Joined: Mon Oct 26, 2020 12:16 pm
Has thanked: 12 times
Been thanked: 19 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by Fiber »

ozeworks wrote: Fri Jan 14, 2022 4:26 pm I feel that this viewtopic.php?f=28&t=1102&p=7941#p7941 issue might be connected to this one. Both triggered by date of birth issues. Could be wrong ...
Yep that is not the solution..
Image
Turn up the Max
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by ecartz »

raiwa wrote: Tue Dec 28, 2021 9:45 am account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
TY. https://github.com/CE-PhoenixCart/Phoen ... 3c0541f77b
Fiber
VIP Member
VIP Member
Posts: 121
Joined: Mon Oct 26, 2020 12:16 pm
Has thanked: 12 times
Been thanked: 19 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by Fiber »

Still not saving dob>account_edit after succesfull create account with dob, also in admin when edit customer, dob remains blanco
Turn up the Max
Fiber
VIP Member
VIP Member
Posts: 121
Joined: Mon Oct 26, 2020 12:16 pm
Has thanked: 12 times
Been thanked: 19 times

Re: 1.0.8.9 Questions / Comments / Concerns

Post by Fiber »

Sorry it works as it should now, made a mistake with editing grmphh
Turn up the Max
Post Reply