Page 1 of 2
1.0.8.9 Questions / Comments / Concerns
Posted: Sun Dec 26, 2021 12:51 pm
by ecartz
Update instructions (from 1.0.8.8):
https://github.com/CE-PhoenixCart/Updat ... /README.md
Update zip:
https://github.com/CE-PhoenixCart/Updat ... update.zip
Release:
https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.9
This is the 1.0.8.9 release, in the 1.0.8.* series. Primary changes:
1. Modernizes the files in includes/system, includes/classes, and includes/languages
2. Makes the row onclick optional in the paginated table component.
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Tue Dec 28, 2021 9:45 am
by raiwa
account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
I didn't try on other places where "dob" is used, but may be the same.
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Thu Jan 06, 2022 9:20 am
by philpla
a happy new year to everyone ...
thx for the new version 1.0.8.9 ... imho the following is wrong:
Code: Select all
includes/system/versioned/1.0.5.4/email.php line 45ff
protected $html_images = [];
protected $attachments = [];
Code: Select all
includes/system/versioned/1.0.5.4/email.php line 225f
$attachments = !Text::is_empty($this->attachments);
$html_images = !Text::is_empty($this->html_images);
Code: Select all
includes/system/versioned/1.0.8.2/text.php line 38
public static function is_empty(string $s = null) {
this gives me a
PHP Fatal error: Uncaught TypeError: Argument 1 passed to Text::is_empty() must be of the type string or null, array given
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Fri Jan 14, 2022 11:07 am
by Fiber
raiwa wrote: ↑Tue Dec 28, 2021 9:45 am
account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
I didn't try on other places where "dob" is used, but may be the same.
Also in admin edit customer, dob still blanco..
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Fri Jan 14, 2022 4:26 pm
by ozeworks
I feel that this
viewtopic.php?f=28&t=1102&p=7941#p7941 issue might be connected to this one. Both triggered by date of birth issues. Could be wrong ...
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Fri Jan 14, 2022 6:04 pm
by raiwa
Code: Select all
'MODULE_CONTENT_IN_CATEGORY_LISTING_DISPLAY_ROW' => [
'title' => 'Categories Per Row',
'value' => 'row row-cols-2 row-cols-sm-3 row-cols-md-4',
'desc' => 'How many categories should display per Row per viewport? Default: XS 2, SM 3, MD and above 4',
],
shows vertical subcategory list.
To show horizontally it should be:
Code: Select all
'value' => 'row cols-2 cols-sm-3 cols-md-4',
Same in the install script.
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Sat Jan 15, 2022 10:23 am
by Fiber
Yep that is not the solution..
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Sat Jan 15, 2022 2:40 pm
by ecartz
raiwa wrote: ↑Tue Dec 28, 2021 9:45 am
account_edit.php doesn't show and save "dob".
When trying to save with empty "dob" it throws:
Notice: Undefined index: dob in C:\xampp_7.4.11\htdocs\master\includes\modules\customer_data\cd_dob.php on line 114
TY.
https://github.com/CE-PhoenixCart/Phoen ... 3c0541f77b
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Sat Jan 15, 2022 3:00 pm
by Fiber
Still not saving dob>account_edit after succesfull create account with dob, also in admin when edit customer, dob remains blanco
Re: 1.0.8.9 Questions / Comments / Concerns
Posted: Sun Jan 16, 2022 10:13 am
by Fiber
Sorry it works as it should now, made a mistake with editing grmphh