Define Question

[Xpajun]

Can some one point me to where IS_PRODUCT_PRODUCTS_DISPLAY_ROW is defined - getting fed up with the thousands of errors a day telling me it's not defined
Thank you

[burt]

https://github.com/search?q=org%3ACE-Ph ... &type=code

You can do this for any piece of code in Phoenix. You can see that this is defined in the installation, so it would be found in your admin area, most likely in the menu > my store ?

Note that (if I recall correctly) there is a bugfix for this area of code (which broke on an update), but I cannot remember what/where exactly.

[ecartz]

This particular result: https://github.com/CE-PhoenixCart/Updat ... update.sql

Indicates that it was added in the update SQL for the 1.0.7.5 update.

[Xpajun]

Thank you Gary @burt and Matt @ecartz for your Input dd a trial run on the updated sql and broke my site again... Fixed now and I'm thinking as I use a horizontal card and only one per row can I not hard code 'IS_PRODUCT_PRODUCTS_DISPLAY_ROW' when it occurs on each card - for me: product_listing.php and cm_i_card_specials.php which are the only two that are causing the errors.

I really need to move on having said I would be working on 1.0.8.5 when I updated my store and still haven't and now 1.0.8.9 is on the doorstep I might just as well install a new version of that and start working on it - the reason I'm looking for a stopgap rather than an answer I suppose although I would rather get it fixed

[burt]

I'm sure there was some issue with the *first* product in a row not icking up this define, the second/third/etc were all fine though. Does this ring a bell @ecartz ?

[ecartz]

I'm sure there was some issue with the *first* product in a row not icking up this define, the second/third/etc were all fine though. Does this ring a bell @ecartz ?

Yes, but that wouldn't show up in 1.0.7.5. And that would have been a different constant.

https://github.com/CE-PhoenixCart/Phoen ... roduct.php

I wouldn't think doing just the insert from the update SQL would cause problems. I can see how custom files might lead to problems from the deletes, but if you skip those and just do the insert, I would expect that to only do good things for you.

Alternately, removing the constant and hard coding the value should not cause problems until the next update.