Page 1 of 2

1.0.8.10 Questions / Comments / Concerns

Posted: Mon Jan 24, 2022 5:06 am
by ecartz
Update instructions (from 1.0.8.9): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... /v1.0.8.10

This is the 1.0.8.10 release, in the 1.0.8.* series. Primary changes:

1. Modernized page templates.
2. Update Chart.js.
3. Modernize core hook files in templates and admin.
4. Modernize template components.
5. Modernize admin currencies and reviews pages.
6. Update admin classes, language files, and other system files.

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Mon Jan 24, 2022 9:29 am
by raiwa
In admin/currencies.php:

When trying to remove a currency:
Notice
: Undefined variable: remove_currency in
C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\actions\currencies\infoboxes\delete.php
on line
29
and no remove button is shown.

When trying to add a new currency:
Fatal error
: Uncaught ArgumentCountError: Too few arguments to function Form::__construct(), 1 passed in C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\actions\currencies\infoboxes\new.php on line 23 and at least 2 expected in C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\includes\system\versioned\1.0.8.1\form.php:27 Stack trace: #0 C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\actions\currencies\infoboxes\new.php(23): Form->__construct('currencies') #1 C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\components\infobox.php(15): require('C:\\xampp_7.4.11...') #2 C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\components\paginated_table.php(85): require('C:\\xampp_7.4.11...') #3 C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\includes\classes\paginator.php(68): include('C:\\xampp_7.4.11...') #4 C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\admin\currencies.php(159): Paginator->display_table() #5 {main} thrown in
C:\xampp_7.4.11\htdocs\xxxxxxxxxxxxxx\includes\system\versioned\1.0.8.1\form.php
on line
27

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Wed Jan 26, 2022 6:32 pm
by tessthepup
Can anyone else confirm that the 'back button' on the 'add a new address' page is not working because the form field requirements have not been met?

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Thu Jan 27, 2022 4:48 am
by ecartz
raiwa wrote: Mon Jan 24, 2022 9:29 am In admin/currencies.php:
TY. https://github.com/CE-PhoenixCart/Phoen ... ce99508559

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Thu Jan 27, 2022 4:49 am
by ecartz
tessthepup wrote: Wed Jan 26, 2022 6:32 pm Can anyone else confirm that the 'back button' on the 'add a new address' page is not working because the form field requirements have not been met?
TY. https://github.com/CE-PhoenixCart/Phoen ... 4b8810a1fa

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Tue Feb 01, 2022 11:24 am
by Brighton
Is there a problem when listing modules>hooks in admin?

Only 8 items are listed, I think there should be more? It seems to fail in modules_hooks.php line 142
Argument #1 ($class) must be a valid class name

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Tue Feb 01, 2022 2:29 pm
by Fiber
Brighton wrote: Tue Feb 01, 2022 11:24 am Is there a problem when listing modules>hooks in admin?

Only 8 items are listed, I think there should be more? It seems to fail in modules_hooks.php line 142
Argument #1 ($class) must be a valid class name
Just tested everything works as it should with new install

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Wed Feb 02, 2022 11:13 am
by Brighton
Fiber wrote: Tue Feb 01, 2022 2:29 pm
Brighton wrote: Tue Feb 01, 2022 11:24 am Is there a problem when listing modules>hooks in admin?

Only 8 items are listed, I think there should be more? It seems to fail in modules_hooks.php line 142
Argument #1 ($class) must be a valid class name
Just tested everything works as it should with new install
How many do you see listed? On a naked install I only see 8, I think there should be about 113?

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Wed Feb 02, 2022 11:47 am
by Fiber
Brighton wrote: Tue Feb 01, 2022 11:24 am I think there should be about 113?
Yep that is correct..

Re: 1.0.8.10 Questions / Comments / Concerns

Posted: Sun Feb 13, 2022 1:06 am
by cristiangliga
When the 'reviews' and 'reviews_description' tables are empty (there are no reviews), in the 'admin/reviews.php' page it shows no error, like this:
Screen Shot 2022-02-12 at 4.56.45 PM.png
If there are reviews in the 'reviews' and 'reviews_description' tables, in the 'admin/reviews.php' page it shows this error:
Screen Shot 2022-02-12 at 4.50.19 PM.png
Additionally, whether or not there are any reviews, when clicking the 'Add A Review' button in the 'admin/reviews.php' page, this Fatal error shows in the 'admin/reviews.php?action=new' page:
Fatal error: Cannot use empty array elements in arrays in /.../admin/includes/actions/reviews/views/save.php on line 43