Page 1 of 1

Please let me know the replacement functions

Posted: Thu Feb 17, 2022 8:15 am
by radhavallabh
Hi dear;
It would be really helpful if I could know the replacement of functions below as I am not able to locate the replacement for the same....
tep_draw_separator function

Thank you in advance;
Warm Regds./
radhavallabh

Re: Please let me know the replacement functions

Posted: Thu Feb 17, 2022 9:02 am
by LeeFoster
There's a spread sheet for it on google sheets.

https://docs.google.com/spreadsheets/d/ ... edit#gid=0

Re: Please let me know the replacement functions

Posted: Thu Feb 17, 2022 9:50 am
by radhavallabh
LeeFoster wrote: Thu Feb 17, 2022 9:02 am There's a spread sheet for it on google sheets.

https://docs.google.com/spreadsheets/d/ ... edit#gid=0
I already checked here dear before writing the post, I could not locate that function in it so asked for help....

Re: Please let me know the replacement functions

Posted: Thu Feb 17, 2022 10:01 am
by ecartz
There is no replacement for tep_draw_separator, as we no longer use it. When @burt does his design lectures, he will presumably discuss alternatives.

It's possible that if you approached this from the other side, people might be able to give more useful advice. I.e. if you show code that currently uses tep_draw_separator, someone might be able to suggest an alternative.

For a concrete example of what I mean, you might consider replacing

Code: Select all

<?= tep_draw_separator() ?>
with

Code: Select all

<hr>

Re: Please let me know the replacement functions

Posted: Thu Feb 17, 2022 10:09 am
by radhavallabh
ecartz wrote: Thu Feb 17, 2022 10:01 am There is no replacement for tep_draw_separator, as we no longer use it. When @burt does his design lectures, he will presumably discuss alternatives.

It's possible that if you approached this from the other side, people might be able to give more useful advice. I.e. if you show code that currently uses tep_draw_separator, someone might be able to suggest an alternative.

For a concrete example of what I mean, you might consider replacing

Code: Select all

<?= tep_draw_separator() ?>
with

Code: Select all

<hr>
Thank you dear;
I will make sure to be more precise on future... :)
I eagerly await the design lectures... Hope they start soon.. :)
Thank you again.
Very warm Regds./
radhavallabh

Re: Please let me know the replacement functions

Posted: Mon Feb 21, 2022 1:33 pm
by burt
tep_draw_seperator is not (as far as I recall) used anywhere in the core code. In old osCommerce it was mainly used in the admin area for placing a "black line" in a table. The old osC admin was a tables based design.

https://github.com/CE-PhoenixCart/Phoen ... _separator

As per Matts post above, what we did in the admin area redesign was to not use the function and instead either do away with the "black line" and just have nothing, or place a horizontal rule instead; <hr> which does the same job in a better way.

Addons may still use it, which is why the function still exists but triggers an error. If an addon does use it, it means that addon is (most likely) not updated to match the current admin layout.

HTH

Re: Please let me know the replacement functions

Posted: Mon Feb 21, 2022 2:07 pm
by ecartz
burt wrote: Mon Feb 21, 2022 1:33 pm In old osCommerce it was mainly used in the admin area for placing a "black line" in a table.
Also, at one point, it was used as a spacer, with pixel_trans.gif (want space between things, just put an invisible element there!). Really old add-ons still have that appearing.