1.0.8.18 Questions / Comments / Concerns

Ask the community for help and support.
Post Reply
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

1.0.8.18 Questions / Comments / Concerns

Post by ecartz »

Update instructions (from 1.0.8.17): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... /v1.0.8.18

This is the 1.0.8.18 release, in the 1.0.8.* series. This is a housekeeping release, updating language file formats and copyright notices. As many store owners have customized their translations, it is not necessary to make those updates in existing stores. So the update just bumps the version number.

Tags:
BrockleyJohn
PhoenixCart Developer
PhoenixCart Developer
Posts: 31
Joined: Mon Mar 01, 2021 5:37 pm
Been thanked: 1 time

Re: 1.0.8.18 Questions / Comments / Concerns

Post by BrockleyJohn »

Admin / modules is ignoring the config sort order and displaying the module settings as it feels.

Sort order values are still getting set correctly on installing a module but are ignored in both view and edit modes.

Gets a bit confusing for complicated payment modules and such!

I guess this came in .17 but I've not installed that yet...
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

Re: 1.0.8.18 Questions / Comments / Concerns

Post by ecartz »

BrockleyJohn wrote: Thu Sep 01, 2022 6:25 pm Admin / modules is ignoring the config sort order and displaying the module settings as it feels.

Sort order values are still getting set correctly on installing a module but are ignored in both view and edit modes.

Gets a bit confusing for complicated payment modules and such!

I guess this came in .17 but I've not installed that yet...
TY. https://github.com/CE-PhoenixCart/Phoen ... 5fed03d4e6

This would have been more understandable if you said that the configuration entries didn't match the order in get_parameters/keys() anymore. As they don't have an explicit sort order. The implicit sort order is what get_parameters provides. So there's no sort order value to be set correctly. Except the order of the modules, which was already correct.
BrockleyJohn
PhoenixCart Developer
PhoenixCart Developer
Posts: 31
Joined: Mon Mar 01, 2021 5:37 pm
Been thanked: 1 time

Re: 1.0.8.18 Questions / Comments / Concerns

Post by BrockleyJohn »

Sorry for the confusion, it never occurred to me to check if the modules page actually uses the configuration sort_order or just sets it and ignores, sorting on something else! Thanks for fix
Post Reply