Page 1 of 1

Rogue file

Posted: Fri Mar 03, 2023 11:57 pm
by Yahalimu
Hi,
I have v1.0.5.0
I'm going through the code to fix deprecated functions so I can move to PHP 8.2 ultimately.
In my pub folder (normally used for product data-sheets for download) I have a compatibility.php file which is full of deprecated functions. (Different from the /includes/compatibility.php file, which is considerably smaller.)
I've searched through the code and nothing ever calls /pub/compatibility.php.
Is it safe to remove it? Is it a remnant of the install process?

Re: Rogue file

Posted: Sat Mar 04, 2023 12:02 am
by Yahalimu
Notes at the top of the file:
////
// Recursively handle magic_quotes_gpc turned off.
// This is due to the possibility of have an array in
// $HTTP_xxx_VARS
// Ie, products attributes

Similar to incudes/compatibilty.php but is quite a bit larger.

Re: Rogue file

Posted: Sat Mar 04, 2023 9:46 am
by ecartz
I am absolutely positive that Phoenix never had a pub/compatibility.php -- it's a bad place to put a code file, as it is the directory available for downloads. I find it unlikely that previous versions put it there for the same reason.

I see three basic possibilities:

1. Someone stuck it there by mistake.
2. There was a hack attempt.
3. An add-on stuck it there.

Only with the third is there any risk of removing it. I'd back it up and remove it. Check for things that are broken.

Re: Rogue file

Posted: Sat Mar 04, 2023 6:16 pm
by Yahalimu
Thanks. I checked github and it wasn't there so I deleted it.
All seems good.
I think it was probably reason 1.