Page 1 of 1

Tax::display()

Posted: Sun May 05, 2024 8:39 am
by heatherbell
This occasionally appearing in error log as a result of a customer action but unable to replicate. 1.0.9.0 and PHP8
Call to undefined method Tax::display() in templates/default/includes/pages
/account_history_info.php:56

Re: Tax::display()

Posted: Tue May 07, 2024 6:04 am
by heatherbell
PHP Fatal error: Uncaught Error: Call to undefined method Tax::display()
This is still appearing from time to time. Is this just a 'me problem'?

Re: Tax::display()

Posted: Tue May 07, 2024 6:35 am
by heatherbell
Maybe mis-reading the code but these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L35-L40
and these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L55-L57
seem to imply that the Tax should display in the table?
But I see this in a clean demo, is this expected?
Screenshot 2024-05-07 073431.png

Re: Tax::display()

Posted: Tue May 07, 2024 9:47 am
by ecartz
Pears aren't taxable.

For the error, TY: https://github.com/CE-PhoenixCart/Phoen ... fd2a13dee7

Re: Tax::display()

Posted: Tue May 07, 2024 10:34 am
by heatherbell
ecartz wrote: Tue May 07, 2024 9:47 am Pears aren't taxable.
Made so to demo.
In any case,
Maybe mis-reading the code but these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L35-L40
and these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L55-L57
seem to imply that the Tax should display in the table?
But I see this in a clean demo (now with Red Apples), is this expected?
Screenshot 2024-05-07 113119.png

Re: Tax::display()

Posted: Tue May 07, 2024 10:52 am
by burt
Looks OK, assuming customer is in Florida..?

You have 7% Florida Tax on Apples and no tax on shipping;

Thus:
Sub Total 4.99 (tax exc)
Post 5 (no tax)
FL Tax 0.35 (tax on 4.99)
Total 10.34 (tax inc)

Re: Tax::display()

Posted: Tue May 07, 2024 10:53 am
by burt
heatherbell wrote: Tue May 07, 2024 10:34 am Maybe mis-reading the code but these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L35-L40
and these lines:
https://github.com/CE-PhoenixCart/Phoen ... hp#L55-L57
seem to imply that the Tax should display in the table?
Should show if multiple tax groups.

Re: Tax::display()

Posted: Tue May 07, 2024 10:56 am
by ecartz
The complaint is that the tax should show in the product table but isn't.

The current behavior dates back to osCommerce. It only shows tax when there is more than one tax group.

Re: Tax::display()

Posted: Tue May 07, 2024 11:09 am
by burt
Ohhh.

You could try removing the if clause and see what happens?
Would need to be tested on both taxable good and non-taxable etc

Re: Tax::display()

Posted: Tue May 07, 2024 11:21 am
by heatherbell
ecartz wrote: Tue May 07, 2024 10:56 am The complaint is that the tax should show in the product table but isn't.
The current behavior dates back to osCommerce. It only shows tax when there is more than one tax group.
No complaint, just an observation and reportage but explanation now makes it clear that it is expected behaviour.