Page 1 of 1
One thing that has kind of bugged me for 20 years...
Posted: Mon Sep 23, 2024 11:37 pm
by frankl
In admin when updating the status of an order, there is the option "This will append your comments to the order and the email."
Turning it off only turns it off for the email.
Comments are still appended and shown in Status History on account_history_info.php shop side.
I always alter core code to not show those comments to customer in Status History - obviously if we don't want the customer to see those comments, we don't want them to see them!
So either code needs to be changed, or that wording should be changed to "This will append your comments to the email."
Re: One thing that has kind of bugged me for 20 years...
Posted: Tue Sep 24, 2024 3:05 am
by heatherbell
frankl wrote: ↑Mon Sep 23, 2024 11:37 pm
that wording should be changed...
Yes, this has been caught before but slipped through the net:
viewtopic.php?p=5360#p5360
A solution is suggested in that topic of incorporating this into core:
app.php/addons/supporters_code/s04e11_admin_comments/
Re: One thing that has kind of bugged me for 20 years...
Posted: Wed Sep 25, 2024 1:48 pm
by burt
@frankl if you wanted to have a play to how you feel it should work, I'd be happy to take that code with the potential of putting into Core.
I have changed the text of ENTRY_NOTIFY_COMMENTS_TEXT;
https://github.com/CE-PhoenixCart/Phoen ... 0777712390
Re: One thing that has kind of bugged me for 20 years...
Posted: Wed Jan 21, 2026 12:35 am
by frankl
Is what I use too simple?
In
templates/default/includes/pages/account_history_info.php
In this query
Code: Select all
$statuses_query = $db->query(sprintf(<<<'EOSQL'
SELECT os.orders_status_name, osh.date_added, osh.comments
FROM orders_status os INNER JOIN orders_status_history osh ON osh.orders_status_id = os.orders_status_id
WHERE os.public_flag = 1 AND osh.orders_id = %d AND os.language_id = %d
ORDER BY osh.date_added
EOSQL
, (int)$_GET['order_id'], (int)$_SESSION['languages_id']));
Add:
So it becomes
Code: Select all
$statuses_query = $db->query(sprintf(<<<'EOSQL'
SELECT os.orders_status_name, osh.date_added, osh.comments
FROM orders_status os INNER JOIN orders_status_history osh ON osh.orders_status_id = os.orders_status_id
WHERE os.public_flag = 1 AND customer_notified = 1 AND osh.orders_id = %d AND os.language_id = %d
ORDER BY osh.date_added
EOSQL
, (int)$_GET['order_id'], (int)$_SESSION['languages_id']));
Or add another tick box
'Show comment shop side?' in
admin/includes/actions/orders/views/edit.php?
Re: One thing that has kind of bugged me for 20 years...
Posted: Sun Jan 25, 2026 1:03 pm
by burt