Page 1 of 2
1.0.8.2 Questions / Comments / Concerns
Posted: Sat Apr 24, 2021 12:50 am
by ecartz
Update instructions (from 1.0.8.1):
https://github.com/CE-PhoenixCart/Updat ... .2/1.0.8.1
Update zip:
https://github.com/CE-PhoenixCart/Updat ... update.zip
Release:
https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.2
This is the 1.0.8.2 release, in the 1.0.8.* series. Primary changes:
1. Continues to replace the old naming scheme.
2. Replaces manually loaded function files with autoloaded class methods.
3. Updates the certificate bundle for use with curl.
4. Updated password handling to BCrypt.
5. Integrated CSRF protection into the admin login page.
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Sun Apr 25, 2021 8:40 pm
by philpla
Thanks for the update.
I found one error on out testpage.
if a customer changes an existing address or tries to delete an address i got:
Undefined index: customers in /var/..../includes/system/versioned/1.0.5.1/customer_write.php
I have just stumbled across this error, it may also be from an earlier update.
Any help is very welcome
thanks
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Sun Apr 25, 2021 9:12 pm
by ecartz
philpla wrote: ↑Sun Apr 25, 2021 8:40 pm
Undefined index: customers in /var/..../includes/system/versioned/1.0.5.1/customer_write.php
Which line number? It should be in the error message.
Note also that my test store does not do this. So you may want to think about how your store is configured differently than the defaults.
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Sun Apr 25, 2021 9:17 pm
by philpla
its line # 73 ( $criteria[$db_table][$foreign_key] = $criteria[$foreign_table][$foreign_key]; )
in function public static function update
it looks like $criteria[$foreign_table='customers'] is undefined
i checked for misconfigs but didnt find the point
maybe you have some hints where to look ... thx
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Mon Apr 26, 2021 12:12 am
by ecartz
Start with the default store. Modify that install to look like your test store step-by-step, testing after each change. When you find the change that causes the problem, concentrate on that one.
Note that the real problem is probably related to 72:
Code: Select all
if (!isset($criteria[$db_table][$foreign_key])) {
Why isn't the customers_id being set on the address_book? Line 73 is only there to fix that when it happens.
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Wed Apr 28, 2021 5:01 pm
by Dnj1964
Getting this error after changing from php 7.3 to 7.4 or 8.0
Switching back to 7.3 and everything works
[28-Apr-2021 16:42:02 UTC] PHP Fatal error: Uncaught Error: Class "mysqli" not found in /home/xxx/public_html/includes/system/versioned/1.0.8.1/database_core.php:13
Stack trace:
#0 /home/xxx/public_html/includes/functions/autoloader.php(125): require()
#1 /home/xxx/public_html/includes/system/versioned/1.0.8.1/database.php(17): tep_autoload_catalog()
#2 /home/xxx/public_html/includes/functions/autoloader.php(125): require('/home/xxx/...')
#3 /home/xxx/public_html/includes/application_top.php(27): tep_autoload_catalog()
#4 /home/xxx/public_html/product_info.php(13): require('/home/xxx/...')
#5 {main}
thrown in /home/xxx/public_html/includes/system/versioned/1.0.8.1/database_core.php on line 13
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Wed Apr 28, 2021 6:05 pm
by ecartz
Dnj1964 wrote: ↑Wed Apr 28, 2021 5:01 pm
Getting this error after changing from php 7.3 to 7.4 or 8.0
[28-Apr-2021 16:42:02 UTC] PHP Fatal error: Uncaught Error: Class "mysqli" not found in
When you update, you have to install the mysqli extension. See
https://stackoverflow.com/questions/666 ... -not-found
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Wed Apr 28, 2021 9:03 pm
by Dnj1964
ecartz wrote: ↑Wed Apr 28, 2021 6:05 pm
Dnj1964 wrote: ↑Wed Apr 28, 2021 5:01 pm
Getting this error after changing from php 7.3 to 7.4 or 8.0
[28-Apr-2021 16:42:02 UTC] PHP Fatal error: Uncaught Error: Class "mysqli" not found in
When you update, you have to install the mysqli extension. See
https://stackoverflow.com/questions/666 ... -not-found
mysql.png
Error
[28-Apr-2021 20:53:36 UTC] PHP Deprecated: Required parameter $objects follows optional parameter $search_str in /home/xxx/public_html/includes/functions/general.php on line 383
[28-Apr-2021 20:53:39 UTC] PHP Deprecated: Required parameter $objects follows optional parameter $search_str in /home/xxx/public_html/includes/functions/general.php on line 383
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Wed Apr 28, 2021 9:18 pm
by Dnj1964
Tried with php 7.3 as well
Re: 1.0.8.2 Questions / Comments / Concerns
Posted: Wed Apr 28, 2021 11:32 pm
by ecartz
Dnj1964 wrote: ↑Wed Apr 28, 2021 9:03 pm
[28-Apr-2021 20:53:36 UTC] PHP Deprecated: Required parameter $objects follows optional parameter $search_str in /home/xxx/public_html/includes/functions/general.php on line 383
[28-Apr-2021 20:53:39 UTC] PHP Deprecated: Required parameter $objects follows optional parameter $search_str in /home/xxx/public_html/includes/functions/general.php on line 383
I'll fix that in core in another version or two. It's just a deprecation warning that will only show in PHP 8. If you don't want to ignore it, change
line 383 of includes/functions/general.phpto
Code: Select all
function tep_parse_search_string($search_str = '', &$objects = []) {
or
Code: Select all
function tep_parse_search_string($search_str, &$objects) {
Beyond that your other Fatal relates to supporters' code. All posts about supporters' code should go in that forum.