1.0.8.4 Questions / Comments / Concerns

Ask the community for help and support.
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

1.0.8.4 Questions / Comments / Concerns

Post by ecartz »

Update instructions (from 1.0.8.3): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update SQL: https://github.com/CE-PhoenixCart/Updat ... update.sql
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.4

This is the 1.0.8.4 release, in the 1.0.8.* series. Primary changes:

1. New class-based install process.
2. Continued migration from legacy compatibility functions to new methods.
3. Updated cacert.pem file.

This is a more limited update than the last one. Still roughly the same size in files, but the most significant changes are to the installer. There have also been some updates to navigation history, account history, and the product listing. Ideally, things should look just the same from the outside, even where things are different under the hood.

Tags:
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 1184
Joined: Sat Dec 21, 2019 8:08 am
Has thanked: 38 times
Been thanked: 102 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by raiwa »

Deleting these files:
install/includes/functions/database.php
install/includes/functions/general.php
install/includes/functions/html_output.php
produces the following errors:

Code: Select all

Warning: require(includes/functions/database.php): failed to open stream: No such file or directory in C:\xampp_7.4.11\htdocs\..............\includes\application_top.php on line 21

Fatal error: require(): Failed opening required 'includes/functions/database.php' (include_path='C:\xampp_7.4.11\php\PEAR') in C:\xampp_7.4.11\htdocs\..............\includes\application_top.php on line 21

Fatal error: Uncaught Error: Call to undefined function tep_not_null() in C:\xampp_7.4.11\htdocs\..............\includes\system\versioned\1.0.5.1\customer_data.php:20 Stack trace: #0 C:\xampp_7.4.11\htdocs\..............\includes\classes\magic\loader.php(16): customer_data->__construct() #1 C:\xampp_7.4.11\htdocs\..............\includes\system\versioned\1.0.8.1\hooks.php(160): Loader->__call('customer_data', Array) #2 C:\xampp_7.4.11\htdocs\..............\includes\application_top.php(30): hooks->generate('startApplicatio...') #3 C:\xampp_7.4.11\htdocs\..............\product_info.php(13): require('C:\\xampp_7.4.11...') #4 {main} thrown in C:\xampp_7.4.11\htdocs\..............\includes\system\versioned\1.0.5.1\customer_data.php on line 20

Fatal error: Uncaught Error: Call to undefined function phoenix_parameterize() in C:\xampp_7.4.11\htdocs\..............\includes\functions\href_link.php:14 Stack trace: #0 C:\xampp_7.4.11\htdocs\..............\includes\modules\boxes\bm_manufacturers.php(46): tep_href_link('index.php', 'manufacturers_i...') #1 C:\xampp_7.4.11\htdocs\..............\includes\modules\boxes\bm_manufacturers.php(78): bm_manufacturers->getData() #2 C:\xampp_7.4.11\htdocs\..............\includes\system\versioned\1.0.7.9\osc_template.php(79): bm_manufacturers->execute() #3 C:\xampp_7.4.11\htdocs\..............\templates\default\includes\components\template_top.php(13): oscTemplate->buildBlocks() #4 C:\xampp_7.4.11\htdocs\..............\templates\default\includes\pages\product_info.php(13): require('C:\\xampp_7.4.11...') #5 C:\xampp_7.4.11\htdocs\..............\product_info.php(25): require('C:\\xampp_7.4.11...') #6 {main} thrown in C:\xampp_7.4.11\htdocs\..............\includes\functions\href_link.php on line 14

In: includes/modules/content/product_info/templates/tpl_cm_pi_gallery.php line 4:
second parameter must be array:

Code: Select all

  $pi_image .= new Image('images/' . $active_image['image'], ['alt' => htmlspecialchars( $active_image['htmlcontent'])]);
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by ecartz »

raiwa wrote: Thu Jun 03, 2021 9:05 am Deleting these files:
install/includes/functions/database.php
install/includes/functions/general.php
install/includes/functions/html_output.php
produces the following errors:
Are you sure you are deleting the correct files? Note that those files are in the install folder, but your errors are coming from includes/application_top.php

Your includes/application_top.php should not be loading any files from the install folder. My guess is that you deleted the files from includes/functions/ not install/includes/functions/
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by ecartz »

raiwa wrote: Thu Jun 03, 2021 9:05 am In: includes/modules/content/product_info/templates/tpl_cm_pi_gallery.php line 4:
second parameter must be array:
TY. https://github.com/CE-PhoenixCart/Phoen ... a9169f6dd4
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 1184
Joined: Sat Dec 21, 2019 8:08 am
Has thanked: 38 times
Been thanked: 102 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by raiwa »

Are you sure you are deleting the correct files?
Ooops, I deleted the wrong files :oops:
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
Nigel
Posts: 107
Joined: Mon Jan 11, 2021 1:39 am
Has thanked: 25 times
Been thanked: 6 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by Nigel »

If I have already added the sql fix and then delete the admin file, install dir already deleted, how does it see my shop as 1.0.8.4 ?
heatherbell
VIP Member
VIP Member
Posts: 1996
Joined: Mon Oct 07, 2019 4:39 am
Has thanked: 26 times
Been thanked: 175 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by heatherbell »

Nigel wrote: Thu Jun 03, 2021 10:30 pmhow does it see my shop as 1.0.8.4 ?
Not sure I understand the question so not sure if this is the answer but if you have updated, the /includes/version.php will have been updated which contains your version.
philpla
Posts: 27
Joined: Sun Feb 28, 2021 8:37 am
Has thanked: 2 times
Been thanked: 1 time

Re: 1.0.8.4 Questions / Comments / Concerns

Post by philpla »

In File includes/modules/content/account/cm_account_gdpr.php
line 17: protected $public_title = MODULE_CONTENT_ACCOUNT_GDPR_LINK_TITLE;
leeds for me to:

Code: Select all

 PHP Fatal error:  Uncaught Error: Cannot declare self-referencing constant 'self::CONFIG_KEY_BASE' in /var/customers/webs/...../admin/modules_content.php:40, referer: https://..../admin/modules_content.php?module=cm_account_gdpr&action=edit
if i move the declaration of $public_title to the constructor like
$this->public_title = MODULE_CONTENT_ACCOUNT_GDPR_LINK_TITLE;

everything is fine

my php version is: 7.3.27-1~deb10u1 (Zend: 3.3.27) and phoenix is 1.0.8.4
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 470
Joined: Tue Oct 13, 2020 5:20 pm
Has thanked: 84 times
Been thanked: 147 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by zipurman »

I just noticed that 1.0.8.4/templates/default/includes/components/product_listing.php

has a the line at the top

Code: Select all

$listing_split = new splitPageResults($listing_sql, $num_list, 'p.products_id');
but $num_list is not defined anywhere.

Previous versions of this file had:

Code: Select all

$num_list = (isset($_GET['view']) && ($_GET['view'] == 'all') ) ? 999999 : MAX_DISPLAY_SEARCH_RESULTS;
but it looks like that line was removed in 1.0.8.4?
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
ecartz
Lead Developer
Lead Developer
Posts: 2637
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 181 times

Re: 1.0.8.4 Questions / Comments / Concerns

Post by ecartz »

zipurman wrote: Mon Jun 07, 2021 12:04 am but it looks like that line was removed in 1.0.8.4?
https://github.com/CE-PhoenixCart/Phoen ... fbf28e128e
Post Reply