I see that the $num_list = ... was removed .... my point is the next line that is still there uses the removed variable .... which now throws an error??
1.0.8.4 Questions / Comments / Concerns
- zipurman
- PhoenixCart Developer
- Posts: 473
- Joined: Tue Oct 13, 2020 5:20 pm
- : Buy Me A Beverage
- Has thanked: 84 times
- Been thanked: 147 times
Re: 1.0.8.4 Questions / Comments / Concerns
zipurman
aka Preston Lord
-----------
Happy to help where I can
https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
aka Preston Lord
-----------
Happy to help where I can
https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Tags:
-
- Lead Developer
- Posts: 2656
- Joined: Tue Nov 05, 2019 6:02 pm
- Has thanked: 4 times
- Been thanked: 182 times
Re: 1.0.8.4 Questions / Comments / Concerns
Well, you might look at the change that I posted and see if it has any other lines referencing num_list. Or just do a global search for num_list. Because core does not throw an error on that line. Which suggests that you are using some add-on that needs to make a parallel change to the one that core made in that same commit.
I suppose it would have been better to have made the change in more isolation (so that the commit would be smaller and easier to find matching changes), but this was a change that I was importing from the product-class branch on the old repository. To break it into smaller changes would have essentially meant redoing the changes. Perhaps I should have. I didn't think of it at the time. Or if I did, I decided it was too much work or too risky (redoing the changes increases the chance of making only half a change).
Please realize that I actually made the change you are discussing six months ago: https://github.com/ecartz/CE-Phoenix/co ... f9859a4ee2
It's just that it only reached core this past release. For the most part, it is a minor change that will, in the future, make it easier to customize the behavior (because this and other parameters are now passed to a hook that can edit them). It's quite possible that you could simplify the add-on now so that it can use the core file where num_files is set, whereas the current version seems to be using an alternative file instead.
- zipurman
- PhoenixCart Developer
- Posts: 473
- Joined: Tue Oct 13, 2020 5:20 pm
- : Buy Me A Beverage
- Has thanked: 84 times
- Been thanked: 147 times
Re: 1.0.8.4 Questions / Comments / Concerns
Yup, you're right. I'll update the mod creating the issue for this version. Sorry for not paying closer attention
zipurman
aka Preston Lord
-----------
Happy to help where I can
https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
aka Preston Lord
-----------
Happy to help where I can
https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Re: 1.0.8.4 Questions / Comments / Concerns
whats that? when i call the modules > content in Admin i get an error 500 now.
Code: Select all
AH01071: Got error 'PHP message: PHP Fatal error: Uncaught Error: Cannot declare self-referencing constant 'self::CONFIG_KEY_BASE' in /home/users/xxxx_de/www/adminxxxx/modules_content.php:38
Stack trace:
#0 {main}
thrown in /home/users/xxxx_de/www/adminxxxx/modules_content.php on line 38', referer: https://xxxx.de/adminxxxx/index.php
Re: 1.0.8.4 Questions / Comments / Concerns
i got the same error and btw. also did report it here see posting viewtopic.php?p=5102#p5102 ... hopefully my workaround is usefullstevang wrote: ↑Mon Jun 07, 2021 1:36 pm whats that? when i call the modules > content in Admin i get an error 500 now.Code: Select all
AH01071: Got error 'PHP message: PHP Fatal error: Uncaught Error: Cannot declare self-referencing constant 'self::CONFIG_KEY_BASE' in /home/users/xxxx_de/www/adminxxxx/modules_content.php:38 Stack trace: #0 {main} thrown in /home/users/xxxx_de/www/adminxxxx/modules_content.php on line 38', referer: https://xxxx.de/adminxxxx/index.php
runs phoenix 1.0.8.12 for testing
webshop for laser cutting goods
webshop for stainless steel products
webshop for laser cutting goods
webshop for stainless steel products
-
- VIP Member
- Posts: 121
- Joined: Mon Oct 26, 2020 12:16 pm
- Has thanked: 12 times
- Been thanked: 19 times
Re: 1.0.8.4 Questions / Comments / Concerns
New install.. see error when clicking on manufactuer Von Peacock..
also on the demoshop van phoenixcart..
Code: Select all
Warning: implode(): Invalid arguments passed in E:\xampp\htdocs\1084\includes\modules\content\index_products\templates\tpl_cm_ip_product_listing.php on line 6
Turn up the Max
-
- Lead Developer
- Posts: 2656
- Joined: Tue Nov 05, 2019 6:02 pm
- Has thanked: 4 times
- Been thanked: 182 times
Re: 1.0.8.4 Questions / Comments / Concerns
TY. https://github.com/CE-PhoenixCart/Phoen ... b2618b17e7Fiber wrote: ↑Tue Jun 08, 2021 5:30 pm New install.. see error when clicking on manufactuer Von Peacock..
also on the demoshop van phoenixcart..Code: Select all
Warning: implode(): Invalid arguments passed in E:\xampp\htdocs\1084\includes\modules\content\index_products\templates\tpl_cm_ip_product_listing.php on line 6
-
- VIP Member
- Posts: 369
- Joined: Tue Oct 27, 2020 4:09 am
- Has thanked: 23 times
- Been thanked: 1 time
Re: 1.0.8.4 Questions / Comments / Concerns
Hi dear,ecartz wrote: ↑Tue Jun 08, 2021 6:22 pmTY. https://github.com/CE-PhoenixCart/Phoen ... b2618b17e7Fiber wrote: ↑Tue Jun 08, 2021 5:30 pm New install.. see error when clicking on manufactuer Von Peacock..
also on the demoshop van phoenixcart..Code: Select all
Warning: implode(): Invalid arguments passed in E:\xampp\htdocs\1084\includes\modules\content\index_products\templates\tpl_cm_ip_product_listing.php on line 6
I was going through the new commit that on line 25 the change is to
SELECT m.*, %s
Can you please guide where will the %s fetched from now (example which php file and code)? as it shall include the omitted p*, pd* etc.....
For my customized shop will need that detail for further upgrades
Thank you again in advance;
Very Warm Regds./
radhavallabh
-
- Lead Developer
- Posts: 2656
- Joined: Tue Nov 05, 2019 6:02 pm
- Has thanked: 4 times
- Been thanked: 182 times
Re: 1.0.8.4 Questions / Comments / Concerns
https://github.com/CE-PhoenixCart/Phoen ... ng.php#L32radhavallabh wrote: ↑Wed Jun 09, 2021 6:05 am Can you please guide where will the %s fetched from now (example which php file and code)? as it shall include the omitted p*, pd* etc.....
https://github.com/CE-PhoenixCart/Phoen ... p#L15..L23
-
- VIP Member
- Posts: 483
- Joined: Fri Oct 25, 2019 5:06 pm
- Has thanked: 48 times
- Been thanked: 28 times
Re: 1.0.8.4 Questions / Comments / Concerns
Certified Phoenix Service Providers feeds links has wrong link for Raiwa
The link should be
not
The link should be
Code: Select all
https://www.oscaddons.com/index.php/en
Code: Select all
https://www.oscaddons.com/en/