1.0.8.6 Questions / Comments / Concerns

Ask the community for help and support.
ecartz
Lead Developer
Lead Developer
Posts: 1447
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 143 times

1.0.8.6 Questions / Comments / Concerns

Post by ecartz »

Update instructions (from 1.0.8.5): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update SQL: https://github.com/CE-PhoenixCart/Updat ... update.sql
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.6

This is the 1.0.8.6 release, in the 1.0.8.* series. Primary changes:

1. More admin flexibility for add-ons.
2. Ongoing conversion from using functions from old function files to new class files.

Tags:
raiwa
PhoenixCart Developer
PhoenixCart Developer
Posts: 495
Joined: Sat Dec 21, 2019 8:08 am
Has thanked: 28 times
Been thanked: 66 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by raiwa »

admin/specials.php throws:
Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112
Seems due to missing quotes.
Adding quotes around 'process_default' fixes it:

Code: Select all

        ($this->table_definition['function'] ?? [$this, 'process_default'])($row);
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
ecartz
Lead Developer
Lead Developer
Posts: 1447
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 143 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by ecartz »

raiwa wrote: Wed Oct 06, 2021 4:46 pm admin/specials.php throws:
Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112
TY. https://github.com/CE-PhoenixCart/Phoen ... 61185862bd
philpla
Posts: 21
Joined: Sun Feb 28, 2021 8:37 am
Has thanked: 2 times
Been thanked: 1 time

Re: 1.0.8.6 Questions / Comments / Concerns

Post by philpla »

thx for the update and the continious work on phoenix!

i think their is a bug / maybe i made an error during update

for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....
runs phoenix 1.0.8.5 for testing
https://shop.aipcalc.de
https://shop.artyle.de
ecartz
Lead Developer
Lead Developer
Posts: 1447
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 143 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by ecartz »

philpla wrote: Mon Oct 18, 2021 3:35 pm for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....
TY: https://github.com/CE-PhoenixCart/Phoen ... 47b8bead65
philpla
Posts: 21
Joined: Sun Feb 28, 2021 8:37 am
Has thanked: 2 times
Been thanked: 1 time

Re: 1.0.8.6 Questions / Comments / Concerns

Post by philpla »

thx, the php fatal error did vanish with this patch, but still something wrong.

in line 15 of admin/includes/actions/orders/infoboxes/delete.php

Code: Select all

  $link = $GLOBALS['Admin']->link()->retain_query_except(['action'])->set_parameter('oID', $table_definition['info']->orders_id);
the var $table_definition['info']->orders_id points everytime to the last order of the page

this affects the delete and edit button of the "new infobox"
the links for invoice and packageslip are ok

thx for helping
runs phoenix 1.0.8.5 for testing
https://shop.aipcalc.de
https://shop.artyle.de
ecartz
Lead Developer
Lead Developer
Posts: 1447
Joined: Tue Nov 05, 2019 6:02 pm
Has thanked: 4 times
Been thanked: 143 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by ecartz »

philpla wrote: Tue Oct 19, 2021 9:07 am to the last order of the page

this affects the delete and edit button of the "new infobox"
TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76
philpla
Posts: 21
Joined: Sun Feb 28, 2021 8:37 am
Has thanked: 2 times
Been thanked: 1 time

Re: 1.0.8.6 Questions / Comments / Concerns

Post by philpla »

thx, this works :)

ecartz wrote: Tue Oct 19, 2021 12:32 pm
philpla wrote: Tue Oct 19, 2021 9:07 am to the last order of the page

this affects the delete and edit button of the "new infobox"
TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76
runs phoenix 1.0.8.5 for testing
https://shop.aipcalc.de
https://shop.artyle.de
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 281
Joined: Tue Oct 13, 2020 5:20 pm
Has thanked: 66 times
Been thanked: 110 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by zipurman »

Error: /includes/modules/order_total/ot_shipping.php on line 39
Trying to access array offset on value of type bool

Occurs when items on order are virtual and do not require shipping. Adding a non-virtual item to the basket will allow for shipping to be chosen and error will no longer occur.

Looks like process() assumes $_SESSION['shipping'] will always be defined.
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
User avatar
zipurman
PhoenixCart Developer
PhoenixCart Developer
Posts: 281
Joined: Tue Oct 13, 2020 5:20 pm
Has thanked: 66 times
Been thanked: 110 times

Re: 1.0.8.6 Questions / Comments / Concerns

Post by zipurman »

HTML error in:
includes/modules/content/index/templates/tpl_cm_i_card_products.php

Line 10:

Code: Select all

<div class="card h-100 is-product" <?= $product->get('data_attributes') ?>">
Has an extra " at the end of the div that should not be there ;)

Issue also exists with:
includes/modules/content/index_nested/templates/tpl_cm_in_card_products.php
zipurman
aka Preston Lord
-----------
Happy to help where I can ;)

https://phoenixaddons.com
https://www.youtube.com/zipurman/ ** PHOENIX HOW-TO VIDEOS **
Image
Post Reply