Page 1 of 1

Product Link Direction Error

Posted: Thu Nov 18, 2021 8:27 pm
by Dnj1964
In 1.0.8.7

Hovering mouse over products shows the product link as

Ex:
/product_info.php?products_id=365
/product_info.php?products_id=363

Clicking the product link opens a new blank page with the word 'Notifications' in the top Left corner.

Re: Product Link Direction Error

Posted: Thu Nov 18, 2021 11:35 pm
by ecartz
Demo shop: https://phoenixcart.org/demo/

Please show me where on the demo shop this occurs. If it does not, then it is not 1.0.8.7 but something else. This is the kind of thing that the certified developers can help you troubleshoot.

Re: Product Link Direction Error

Posted: Fri Nov 19, 2021 7:36 pm
by Dnj1964
ecartz wrote: Thu Nov 18, 2021 11:35 pm Demo shop: https://phoenixcart.org/demo/

Please show me where on the demo shop this occurs. If it does not, then it is not 1.0.8.7 but something else. This is the kind of thing that the certified developers can help you troubleshoot.
I ask for suggestions or ideas as to where to possibly look, trying to learn a little along the way. Not in any great rush. Thanks

Re: Product Link Direction Error

Posted: Fri Nov 19, 2021 7:51 pm
by Dnj1964
My error log

Code: Select all

[19-Nov-2021 19:46:27 UTC] PHP Fatal error:  Uncaught Error: Call to undefined method Href::request_query_except() in /includes/modules/boxes/templates/tpl_bm_product_notifications.php:6

Stack trace:
#0 /includes/modules/block_template.php(14): include()
#1 /includes/modules/boxes/bm_product_notifications.php(32): include('/...')
#2 /includes/system/versioned/1.0.7.9/osc_template.php(79): bm_product_notifications->execute()
#3 /templates/default/includes/components/template_top.php(13): oscTemplate->buildBlocks()
#4 /templates/default/includes/pages/product_info.php(13): require('/...')
#5 /product_info.php(25): require('/...')
#6 {main}
  thrown in /includes/modules/boxes/templates/tpl_bm_product_notifications.php on line 6

Re: Product Link Direction Error

Posted: Sat Nov 20, 2021 2:49 am
by ecartz
Dnj1964 wrote: Fri Nov 19, 2021 7:51 pm [19-Nov-2021 19:46:27 UTC] PHP Fatal error: Uncaught Error: Call to undefined method Href::request_query_except() in /includes/modules/boxes/templates/tpl_bm_product_notifications.php:6
TY. https://github.com/CE-PhoenixCart/Phoen ... 7733fd1b7e

Re: Product Link Direction Error

Posted: Sun Nov 21, 2021 4:22 am
by Dnj1964
ecartz wrote: Sat Nov 20, 2021 2:49 am
Dnj1964 wrote: Fri Nov 19, 2021 7:51 pm [19-Nov-2021 19:46:27 UTC] PHP Fatal error: Uncaught Error: Call to undefined method Href::request_query_except() in /includes/modules/boxes/templates/tpl_bm_product_notifications.php:6
TY. https://github.com/CE-PhoenixCart/Phoen ... 7733fd1b7e
Thank you that change works perfectly
Am I correct in that the only change was "request" changed to "retain"

Considering no one else chimed in I can only assume that it was a unique problem to my install.

Pretty much a basic 1.0.8.7 installation with a shipping mod by @zipurman and a hybrid dropdown courtesy of @heatherbell.

Many thanks to @burt, @heatherbell and @ecartz the knowledge and help you all provide to everyone is amazing.

Don't want to speak for anyone else but the ease with which you all can troubleshoot and fix problems is absolutely incredible.

Attempting to go from PHP kindergarten to a doctorate overnight is impossible, although I continue to watch videos and attempt to learn a tiny bit.

Re: Product Link Direction Error

Posted: Sun Nov 21, 2021 5:59 am
by heatherbell
Dnj1964 wrote: Sun Nov 21, 2021 4:22 am Am I correct in that the only change was "request" changed to "retain"
Yes.
Dnj1964 wrote: Sun Nov 21, 2021 4:22 am TY. https://github.com/CE-PhoenixCart/Phoen ... 7733fd1b7e
Considering no one else chimed in I can only assume that it was a unique problem to my install.
No, you found an issue that nobody else had yet so good job for reporting it. You'll see in that GitHub link that the fix has been made in 1.0.8.8 so thanks to your report, nobody else will have that issue in the next version.
Dnj1964 wrote: Sun Nov 21, 2021 4:22 am Attempting to go from PHP kindergarten to a doctorate overnight is impossible, although I continue to watch videos and attempt to learn a tiny bit.
That's how it starts! Phoenix is a 'gateway drug' - it won't be long before you start itching and cold sweating if you're not coding! (but trying to code often makes me feel that way!) ;)