Updating Old FAQ Addon

[radhavallabh]

@ecartz @raiwa

All sorted and fixed

Thanks for the help guys.

Would this be of interest to people as an addon if I was to upload it?

I shall be interested too dear as currently I need to put a accordian open close html code to each question for which the answer needs to be seen and it behaves very abnormally.....
Thank you in advance;
Very Warm Regds./
radhavallabh

[tessthepup]

ok got myself a little bit stuck on converting some old links. There are no errors thrown but the status links just do not work.

This is the old code

Code: Select all

<?php  
        if ($val['visible'] == 1) {
            echo '<i class="fas fa-circle dovisible"></i>&nbsp;&nbsp;
            <a href="' . tep_href_link('faq_manager.php', "faq_action=Visible&faq_id=$val[faq_id]&visible=$val[visible]") . '">
            <i class="fas fa-circle dohidden_lite"></i></a>';
        }else {
            echo '<a href="' . tep_href_link('faq_manager.php', "faq_action=Visible&faq_id=$val[faq_id]&visible=$val[visible]") . '">
            <i class="fas fa-circle dovisible_lite"></i>&nbsp;&nbsp;</a>		
            <i class="fas fa-circle dohidden"></i>';
        };
        ?>

and this is what I have

Code: Select all

<?php  
        if ($val['visible'] == 1) {
            echo '<i class="fas fa-circle dovisible"></i>&nbsp;&nbsp;
            <a href="' . $Admin->link('faq_manager.php', ['faq_action' => 'Visible&faq_id=$val[faq_id]&visible=$val[visible]']) . '">                        
            <i class="fas fa-circle dohidden_lite"></i></a>';
        }else {
            echo '<a href="' . $Admin->link('faq_manager.php', ['faq_action' => 'Visible&faq_id=$val[faq_id]&visible=$val[visible]']) . '">
            <i class="fas fa-circle dovisible_lite"></i>&nbsp;&nbsp;</a>		
            <i class="fas fa-circle dohidden"></i>';
        };
        ?>

[ecartz]

Code: Select all

<?php
        $flag_link = $Admin->link('faq_manager.php', ['faq_action' => 'Visible', 'faq_id' => $val['faq_id'], 'visible' => $val['visible']]);
        if ($val['visible'] == 1) {
            echo <<<"EOHTML"
            <i class="fas fa-circle dovisible"></i>&nbsp;&nbsp;
            <a href="$flag_link">                        
            <i class="fas fa-circle dohidden_lite"></i></a>
EOHTML;
        }else {
            echo <<<"EOHTML"
            <a href="$flag_link">
            <i class="fas fa-circle dovisible_lite"></i>&nbsp;&nbsp;</a>		
            <i class="fas fa-circle dohidden"></i>
EOHTML;
        };
        ?>

[tessthepup]

Code: Select all

<?php
        $flag_link = $Admin->link('faq_manager.php', ['faq_action' => 'Visible', 'faq_id' => $val['faq_id'], 'visible' => $val['visible']]);
        if ($val['visible'] == 1) {
            echo <<<"EOHTML"
            <i class="fas fa-circle dovisible"></i>&nbsp;&nbsp;
            <a href="$flag_link">                        
            <i class="fas fa-circle dohidden_lite"></i></a>
EOHTML;
        }else {
            echo <<<"EOHTML"
            <a href="$flag_link">
            <i class="fas fa-circle dovisible_lite"></i>&nbsp;&nbsp;</a>		
            <i class="fas fa-circle dohidden"></i>
EOHTML;
        };
        ?>

@ecartz

Hi Matt, I have been trying to replace tep_draw_form and looked and tried just about every example in core I could find but can not seem to get it to work.

Any chance of picking your brains again

Code: Select all

echo tep_draw_form('faq_manager','faq_manager.php', 'faq_action=Update');    
     echo tep_draw_hidden_field('faq_id', $faq_id);

Thanks

Mark

[ecartz]

Code: Select all

echo (new Form('faq_manager', $Admin->link('faq_manager.php', ['faq_action' => 'Update']))->hide('faq_id', $faq_id);

[tessthepup]

Code: Select all

echo (new Form('faq_manager', $Admin->link('faq_manager.php', ['faq_action' => 'Update']))->hide('faq_id', $faq_id);

@ecartz

Thanks Matt

[tessthepup]

@ecartz

I think I am just about done in converting the old code to the new however I have these warnings which I have never seen before

PHP Notice: Array to string conversion in /home/store/public_html/includes/system/class_index.php on line 38

PHP Notice: Array to string conversion in /home/store/public_html/admin/includes/application_top.php on line 134

They only appear when saving a new FAQ and not editing then saving.

Would it be something to do with the way the language is handled on save? (only guessing)

[ecartz]

Look for something like

Code: Select all

foreach (language::load_all() as $language) {

[tessthepup]

Look for something like

Code: Select all

foreach (language::load_all() as $language) {

@ecartz

Thanks again Matt, all errors debugged apart from when testing on PHP 8.1 I get this error

PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given in

This is the offending line

Code: Select all

if (count($languages) > 1) {

[ecartz]

That error would go away if you changed the line to

Code: Select all

if (is_array($languages) && (count($languages) > 1)) {

But a better solution might be to change whatever is setting $languages to be a string. Because it may have other side effects.