Need a check done on 1.0.9.0 downloads system

[14Steve14]

1.0.9.0. and php8.0

Is there anyone that can offer me a bit of help by checking the downloads system on 1.0.9.0. For what ever reason whether the download is free or paid I am getting a shipping error during checkout.

When progressing through the checkout I have one free and one paid for download in the basket. Both of the items have a shipping weight of zero so they should be a virtual product.

The items show in the cart correctly, and when logged in and checking out I get redirected to the checkout_shipping_address.php page, without seeing the shipping options page, with a message saying that there are no shipping options for the selected address.

If I change the address to even another country apart from the UK I still get the warning message. If I add a paid for product into the basket the message goes away and checkout continues as it should.

There is an error in the log files which is

[29-Apr-2024 08:47:29 Europe/London] PHP Warning: Undefined array key "shipping_method" in /home/####/public_html/####/includes/modules/order_total/ot_shipping.php on line 41

Is there anyone that uses either free or paid for downloads that can just confirm that the checkout does work correctly. If so I will have to start looking for what is causing the problem.

[14Steve14]

Been doing a bit more testing and am no further forward with this. I have found that the error is nothing to do with the problem as far as I can tell as I looked into that and now have no errors in the log files.

Check through files and removed any overwritten files in the overwrite folder that may affect things and the problem is still there.

Could this be anything to do with when the database was converted. Everything does look the same when comparing new and old tables.

[raiwa]

Could it be a non core shipping module which doesn't return a shipping method if not available because it's a virtual order?

[14Steve14]

Could it be a non core shipping module which doesn't return a shipping method if not available because it's a virtual order?

@raiwa Thanks for the reply.

Not too sure how the core modules handle virtual products. I have removed all of the non core modules and tried three of the four core shipping modules and they all showed a shipping cost on either a free or paid for download. I didnt use the zones one.

I did have Gary code me some new modules that catered for free and virtual items so i may be back to him to check his code. If nothing else he may allow me to post the code here for others to see what is going wrong.

[14Steve14]

Not sure that this is a shipping module error. I am slowly working my way through replacing all the core files that I cqn find that relate to shipping and as yet nothing has changed. All virtual products ask for shipping.

I am going to try uploading a copy of the latest version and then use the modified test sites database and see whether it works as it should when only code files are loaded.

I will let you know how I get on.

[burt]

Notes;

1. in all the years I've used osc/ce/bs/phoenix, I have never set up a downloadable product. I followed the instructions here; https://phoenixcart.org/phoenixcartwiki ... e=Download
2. i'm testing in an out of the box 1.0.9.2 as that is all I have available at the moment

Set up as per #1 above.
Checkout, I find NO PAYMENT METHOD available - as Cash on Delivery is the out of the box install, and COD does not allow the purchase of a "virtual" order. I install Cheque payment. Select this. Next.

Shipping is completely skipped. As expected, as there is no need to ship a totally virtual order.

So, my limited testing...seems to work as expected..

[raiwa]

I recently updated my site Phoenixcartaddons to 1.0.9.1 and have download setup without any issues.

[14Steve14]

Thanks to @burt and @raiwa . Looks like I have some figuring out to do. I have been away for a few days so will start chasing this down before I get much further.

This test store now has an updated database from a copy of my current store so all the download files were already created and do seem to show as they should after the update. They are all present in the admin back end. I only had one problem with one of the download products which was removed and a new copy created.

I have turned off all the shipping modules that were created for me and installed just one of the core modules and the problem is still there. I have removed all the files from my override file, which hopefully puts things back to standard and the problem is still there. I thought I had been a good boy and overrode everything I could, but may have changed something and not actually got as far as adding to the override folder after testing the core change.

Silly question but would it be possible to overwrite all my 1.9.0 core files with a copy of 1.0.9.1 as if I was doing an update and see what happens then. As long as I keep a backup of the current files I should be alright shouldn't I if things go wrong.