Preview of 1.0.8.16

[ecartz]

Now released at viewtopic.php?f=10&t=1424

This is a bugfix release. I expect to do a normal release next month.

[Fiber]

New Install

Sending newsletter in Newsletter Manager:

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\newsletter.php on line 42

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\newsletter.php on line 43
===
What is normal behavior with product notification in admin? Newsletter Manager>New Newsletter>module product_ notification>title>content>save>lock>send>select>Lemons>>>select Lemons in right Tab and click send, notification comes in, but shouldn't there also be a link from Lemons?

I would expect because I selected Lemons that there would be something from Lemons on display? Don't even know how it used to be.

I don't really understand what product_notification should do, it's just an email like this..


Also these Notice:

Notice: Array to string conversion in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 111

Notice: Array to string conversion in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 111

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 127

[ecartz]

I don't really understand what product_notification should do, it's just an email

That's all that it does. People subscribe to a "newsletter" about that product. The content of the newsletter is entirely arbitrary. All that Phoenix provides is the framework of people subscribing. The email content could be anything. E.g.

1. This product is back in stock, order now!
2. This product is permanently out of stock, please switch to [some other product].
3. This product has been updated! Consider buying a new copy.

Phoenix simply limits the notification to people who actively subscribed for notifications like that. The content itself is up to the store owner. It sends the same content to every subscriber.

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\newsletter.php on line 42

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\newsletter.php on line 43

TY. https://github.com/CE-PhoenixCart/Phoen ... 91d1483526

Notice: Array to string conversion in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 111

Notice: Array to string conversion in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 111

I don't get these and don't see how 111 would produce them. What do your lines 109-112 say? Mine says

Code: Select all

      $audience = array_unique(array_merge(
        $GLOBALS['db']->fetch_all($sql),
        $GLOBALS['db']->fetch_all("SELECT customers_info_id FROM customers_info WHERE global_product_notifications = 1")
        ));

[Fiber]

That's all that it does. People subscribe to a "newsletter" about that product. The content of the newsletter is entirely arbitrary. All that Phoenix provides is the framework of people subscribing. The email content could be anything. E.g.

1. This product is back in stock, order now!
2. This product is permanently out of stock, please switch to [some other product].
3. This product has been updated! Consider buying a new copy.

Phoenix simply limits the notification to people who actively subscribed for notifications like that. The content itself is up to the store owner. It sends the same content to every subscriber.

Ok a little clearer..

I don't get these and don't see how 111 would produce them. What do your lines 109-112 say? Mine says

Code: Select all

      $audience = array_unique(array_merge(
        $GLOBALS['db']->fetch_all($sql),
        $GLOBALS['db']->fetch_all("SELECT customers_info_id FROM customers_info WHERE global_product_notifications = 1")
        ));

Exactly the same

[ecartz]

You could try it as

Code: Select all

      $audience = array_unique(array_merge(
        array_column($GLOBALS['db']->fetch_all($sql), 'customers_id'),
        array_column($GLOBALS['db']->fetch_all("SELECT customers_info_id FROM customers_info WHERE global_product_notifications = 1"), 'customers_info_id')
        ));

And see if that helps.

[Fiber]

And see if that helps.

Now i get:
Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 127

@Just to be sure, downloaded the files from Github, to rule out copy and paste errors.

[ecartz]

Notice: Undefined index: page in E:\xampp\htdocs\10816beta\admin06\includes\modules\newsletters\product_notification.php on line 127

TY. https://github.com/CE-PhoenixCart/Phoen ... e42954f596