Are there any plans/roadmap to add support for PHP 8.1?
As a first step from PHP 8.0 to PHP 8.2 I restarted testing with PHP 8.1.
Adding support for PHP 8.1?
Adding support for PHP 8.1?
Last edited by cdgo on Sun Apr 09, 2023 8:33 am, edited 1 time in total.
- burt
- Core Team
- Posts: 4551
- Joined: Tue Oct 29, 2019 9:37 am
- Phoenix Version: v1.1.0.8
- : Buy Me A Beverage
- Has thanked: 252 times
- Been thanked: 412 times
Re: Adding support for PHP 8.2?
What part(s) of Phoenix fail in 8.2 ?
I am not here to build for you.
I am here to build with you. Let's help each other.
I am here to build with you. Let's help each other.
Re: Adding support for PHP 8.2?
Hi Burt,
I think it's more the add-ons than core, but I'll make a list if any for the core, and add them to this thread.
I think it's more the add-ons than core, but I'll make a list if any for the core, and add them to this thread.
Re: Adding support for PHP 8.2?
The basic operations seem solid for PHP 8.2. Nicely done, Burt and team!
- burt
- Core Team
- Posts: 4551
- Joined: Tue Oct 29, 2019 9:37 am
- Phoenix Version: v1.1.0.8
- : Buy Me A Beverage
- Has thanked: 252 times
- Been thanked: 412 times
Re: Adding support for PHP 8.2?
I am in a php8.2 sandbox, running the upcoming bootstrap 5 theme.
So far, everything seems solid.
If I find anything, I will also post back to this thread.
So far, everything seems solid.
If I find anything, I will also post back to this thread.
I am not here to build for you.
I am here to build with you. Let's help each other.
I am here to build with you. Let's help each other.
Re: Adding support for PHP 8.2?
Possibly the same question @cdgo intended: when will the home page for PhoenixCart show that it has been tested higher than 8.0 (what it shows now)? Seems like it might be reasonable to bump that number to at least 8.1, if not 8.2.
-
ecartz
- Core Team
- Posts: 3084
- Joined: Tue Nov 05, 2019 6:02 pm
- Phoenix Version:
- Has thanked: 4 times
- Been thanked: 208 times
Re: Adding support for PHP 8.2?
Last time I bumped it (to 8.0), it was after I, myself, had it running on 8.0. For various reasons, it's unlikely that I will run on either 8.1 or 8.2 any time soon. Perhaps Burt will bump it this time.
Re: Adding support for PHP 8.2?
I'm finding a few warning logs in PHP 8.1. I'm opening issues for them and would be happy to PR.
Re: Adding support for PHP 8.2?
One of the issues which ofcourse is not directly caused by the core, but I think should be handled by the core is the failling of translations:
PHP Fatal error: Uncaught Error: Undefined constant "TITLE" in /home/user/domains/domain/public_html/includes/classes/application.php:65
The adding of all the nessecary translations is part of the added plugin, but there should be a fallback to prevent the whole shop to seize working when only a translations is missing.
Most likely it happens in the additional languages so a fallback to the default language should be working for those cases.
And if it is in the default language, a default output could be used like "mising translation" or even just one space.
PHP Fatal error: Uncaught Error: Undefined constant "TITLE" in /home/user/domains/domain/public_html/includes/classes/application.php:65
The adding of all the nessecary translations is part of the added plugin, but there should be a fallback to prevent the whole shop to seize working when only a translations is missing.
Most likely it happens in the additional languages so a fallback to the default language should be working for those cases.
And if it is in the default language, a default output could be used like "mising translation" or even just one space.
Re: Adding support for PHP 8.1?
PHP Deprecated: Function strftime() is deprecated in /home/user/domains/domain/public_html/includes/modules/content/index/templates/tpl_cm_i_card_products.php
Function strftime() should be replaced by:
$formatter = new IntlDateFormatter('nl_NL', IntlDateFormatter::LONG, IntlDateFormatter::NONE);
echo $formatter->format(time());
Function strftime() should be replaced by:
$formatter = new IntlDateFormatter('nl_NL', IntlDateFormatter::LONG, IntlDateFormatter::NONE);
echo $formatter->format(time());
Last edited by cdgo on Sun Apr 09, 2023 9:36 am, edited 1 time in total.