Page 1 of 2

1.0.8.6 Questions / Comments / Concerns

Posted: Wed Sep 29, 2021 10:10 am
by ecartz
Update instructions (from 1.0.8.5): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update SQL: https://github.com/CE-PhoenixCart/Updat ... update.sql
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.6

This is the 1.0.8.6 release, in the 1.0.8.* series. Primary changes:

1. More admin flexibility for add-ons.
2. Ongoing conversion from using functions from old function files to new class files.

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Wed Oct 06, 2021 4:46 pm
by raiwa
admin/specials.php throws:
Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112
Seems due to missing quotes.
Adding quotes around 'process_default' fixes it:

Code: Select all

        ($this->table_definition['function'] ?? [$this, 'process_default'])($row);

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Thu Oct 07, 2021 2:22 am
by ecartz
raiwa wrote: Wed Oct 06, 2021 4:46 pm admin/specials.php throws:
Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112
TY. https://github.com/CE-PhoenixCart/Phoen ... 61185862bd

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Mon Oct 18, 2021 3:35 pm
by philpla
thx for the update and the continious work on phoenix!

i think their is a bug / maybe i made an error during update

for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Tue Oct 19, 2021 1:29 am
by ecartz
philpla wrote: Mon Oct 18, 2021 3:35 pm for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....
TY: https://github.com/CE-PhoenixCart/Phoen ... 47b8bead65

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Tue Oct 19, 2021 9:07 am
by philpla
thx, the php fatal error did vanish with this patch, but still something wrong.

in line 15 of admin/includes/actions/orders/infoboxes/delete.php

Code: Select all

  $link = $GLOBALS['Admin']->link()->retain_query_except(['action'])->set_parameter('oID', $table_definition['info']->orders_id);
the var $table_definition['info']->orders_id points everytime to the last order of the page

this affects the delete and edit button of the "new infobox"
the links for invoice and packageslip are ok

thx for helping

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Tue Oct 19, 2021 12:32 pm
by ecartz
philpla wrote: Tue Oct 19, 2021 9:07 am to the last order of the page

this affects the delete and edit button of the "new infobox"
TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Tue Oct 19, 2021 1:25 pm
by philpla
thx, this works :)

ecartz wrote: Tue Oct 19, 2021 12:32 pm
philpla wrote: Tue Oct 19, 2021 9:07 am to the last order of the page

this affects the delete and edit button of the "new infobox"
TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Wed Oct 27, 2021 5:36 am
by zipurman
Error: /includes/modules/order_total/ot_shipping.php on line 39
Trying to access array offset on value of type bool

Occurs when items on order are virtual and do not require shipping. Adding a non-virtual item to the basket will allow for shipping to be chosen and error will no longer occur.

Looks like process() assumes $_SESSION['shipping'] will always be defined.

Re: 1.0.8.6 Questions / Comments / Concerns

Posted: Wed Oct 27, 2021 6:45 am
by zipurman
HTML error in:
includes/modules/content/index/templates/tpl_cm_i_card_products.php

Line 10:

Code: Select all

<div class="card h-100 is-product" <?= $product->get('data_attributes') ?>">
Has an extra " at the end of the div that should not be there ;)

Issue also exists with:
includes/modules/content/index_nested/templates/tpl_cm_in_card_products.php