1.0.8.6 Questions / Comments / Concerns

[ecartz]

Update instructions (from 1.0.8.5): https://github.com/CE-PhoenixCart/Updat ... /README.md
Update SQL: https://github.com/CE-PhoenixCart/Updat ... update.sql
Update zip: https://github.com/CE-PhoenixCart/Updat ... update.zip
Release: https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.8.6

This is the 1.0.8.6 release, in the 1.0.8.* series. Primary changes:

1. More admin flexibility for add-ons.
2. Ongoing conversion from using functions from old function files to new class files.

[raiwa]

admin/specials.php throws:

Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112

Seems due to missing quotes.
Adding quotes around 'process_default' fixes it:

Code: Select all

        ($this->table_definition['function'] ?? [$this, 'process_default'])($row);

[ecartz]

admin/specials.php throws:

Warning: Use of undefined constant process_default - assumed 'process_default' (this will throw an Error in a future version of PHP) in C:\xampp_7.4.11\htdocs\***********\admin\includes\classes\paginator.php on line 112

TY. https://github.com/CE-PhoenixCart/Phoen ... 61185862bd

[philpla]

thx for the update and the continious work on phoenix!

i think their is a bug / maybe i made an error during update

for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....

[ecartz]

for admin/orders.php if i press "delete" button for a selected order it throws:

Code: Select all

PHP Notice:  Undefined variable: oInfo in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Notice:  Trying to get property 'orders_id' of non-object in /var/XXXX/admin/includes/actions/orders/infoboxes/delete.php on line 15
PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Href::set_parameter() must be of the type string, null given ....

TY: https://github.com/CE-PhoenixCart/Phoen ... 47b8bead65

[philpla]

thx, the php fatal error did vanish with this patch, but still something wrong.

in line 15 of admin/includes/actions/orders/infoboxes/delete.php

Code: Select all

  $link = $GLOBALS['Admin']->link()->retain_query_except(['action'])->set_parameter('oID', $table_definition['info']->orders_id);

the var $table_definition['info']->orders_id points everytime to the last order of the page

this affects the delete and edit button of the "new infobox"
the links for invoice and packageslip are ok

thx for helping

[ecartz]

to the last order of the page

this affects the delete and edit button of the "new infobox"

TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76

[philpla]

thx, this works

to the last order of the page

this affects the delete and edit button of the "new infobox"

TY. https://github.com/CE-PhoenixCart/Phoen ... 6c3c10dd76

[zipurman]

Error: /includes/modules/order_total/ot_shipping.php on line 39
Trying to access array offset on value of type bool

Occurs when items on order are virtual and do not require shipping. Adding a non-virtual item to the basket will allow for shipping to be chosen and error will no longer occur.

Looks like process() assumes $_SESSION['shipping'] will always be defined.

[zipurman]

HTML error in:
includes/modules/content/index/templates/tpl_cm_i_card_products.php

Line 10:

Code: Select all

<div class="card h-100 is-product" <?= $product->get('data_attributes') ?>">

Has an extra " at the end of the div that should not be there

Issue also exists with:
includes/modules/content/index_nested/templates/tpl_cm_in_card_products.php