a small step for a man... some issues after update

[Denzel]

Back again After some month of absence, I'm back for updates Glad to see, that everythink is going straight forward, many thanks to all developers and supporters and all app coders !
I made a big leap last night: From v1.0.7.9 to v1.0.8.15 But very nice with Zipurmans Updater Shopsite is allright already. I've got some issues on the backend. Maybe someone with more overview about the changes can give me a hint for finding the bugs
All backend:
- categorys appears twice: my old categories.php and a new catalog.php... better than if it had completely disappeared -> already found: delete one

- security check seems to load till death same as here: viewtopic.php?p=8714#p8714 While a fresh 1.0.8.16 install throws Fatal error: Uncaught ValueError: curl_setopt_array(): Argument #2 ($options) must contain only valid cURL options in /admin/includes/classes/security_checks.php:104 on the same server...

- modules_actions.php told me Warning: Invalid argument supplied for foreach() in /admin/modules_actions.php on line 38 (6 times!)

and last but not least:
- Customer_data_groups.php tell me of undefined constant TEXT_DISPLAY_NUMBER_OF_CUSTOMER_DATA_GROUPS

oh, and some of the gdpr modules are bitching around, but I think there are updates somewhere...
I've also read that usu no longer works, maybe I'll test Raiwa's version. Can you turn off the -c- and -p- in the url? @raiwa
What i've done till now? Reading all the update threads and fixed a lot of bugs already. Now im stuck
php says v5.4.30, MySQL 4.4.302. Many thanks to everyone who has read up to here. Maybe someone has a hint for me

Regards,
Denzel

[raiwa]

I've also read that usu no longer works, maybe I'll test Raiwa's version. Can you turn off the -c- and -p- in the url? @raiwa

This is not possible. They are required markers to identify category and product.

[Denzel]

I've also read that usu no longer works, maybe I'll test Raiwa's version. Can you turn off the -c- and -p- in the url? @raiwa

This is not possible. They are required markers to identify category and product.

Maybe there is a way only for categorys with unique names ? My SEO doctor told me, that it were better to have continually paths e.g. fruits.html and then fruits/lime-p9.html

[ecartz]

- Customer_data_groups.php tell me of undefined constant TEXT_DISPLAY_NUMBER_OF_CUSTOMER_DATA_GROUPS

Did you do your own translation (I assume that your store is in Deutsch)?

English: https://github.com/CE-PhoenixCart/Phoen ... sh.php#L92

php says v5.4.30, MySQL 4.4.302.

Minimum requirements: https://github.com/CE-PhoenixCart/Phoen ... quirements

That's PHP 7 and MySQL 5.7.7.

I suspect that at least some of your problems relate to the PHP version. In particular, the curl options (could also be the curl version; I'm making some changes this month to better support old curl versions). Also quite possibly modules_actions.php

[Denzel]

- Customer_data_groups.php tell me of undefined constant TEXT_DISPLAY_NUMBER_OF_CUSTOMER_DATA_GROUPS

Did you do your own translation (I assume that your store is in Deutsch)?

English: https://github.com/CE-PhoenixCart/Phoen ... sh.php#L92

php says v5.4.30, MySQL 4.4.302.

Minimum requirements: https://github.com/CE-PhoenixCart/Phoen ... quirements

That's PHP 7 and MySQL 5.7.7.

I suspect that at least some of your problems relate to the PHP version. In particular, the curl options (could also be the curl version; I'm making some changes this month to better support old curl versions). Also quite possibly modules_actions.php

I'm sorry, I think I'm hanging around the maschine too long... This was a typo: php is 7.4.30 and MySQL 5.7.38. Too bad, shortly i had hopes...

It's true, my shop is in german, and I've missed that this translation is located in the root language file -> fixed it TY !

See Ya
Denzel

[raiwa]

I've also read that usu no longer works, maybe I'll test Raiwa's version. Can you turn off the -c- and -p- in the url? @raiwa

This is not possible. They are required markers to identify category and product.

Maybe there is a way only for categorys with unique names ? My SEO doctor told me, that it were better to have continually paths e.g. fruits.html and then fruits/lime-p9.html

Name based URLs is based on the former Ultimate SEO URLs by Chemo. The coding doesn't allow to remove the markers and IDs. This would require a different coding approach. As far as I know, only 2 URL rewriters (SEO G and John Barounis's SEO Friendly Urls) existed before which were not using ID markers. Both are discontinued.

I'm not a SEO specialist, but as far as I know:
- URLs have a very minor influence on SEO.
- Depending on your category-product title structure, it might be better not to use category names at all in the product path. Like this your product title will be at the first hierarchy level.

[Denzel]

- modules_actions.php told me Warning: Invalid argument supplied for foreach() in /admin/modules_actions.php on line 38 (6 times!)

This was due to not updated wishlist and empty cart addons -> now fixed

[Denzel]

- Depending on your category-product title structure, it might be better not to use category names at all in the product path. Like this your product title will be at the first hierarchy level.

I'll talk to the SEO doc and see what's his opinion. Thanks for the input

[Denzel]

- security check seems to load till death same as here: viewtopic.php?p=8714#p8714 While a fresh 1.0.8.16 install throws Fatal error: Uncaught ValueError: curl_setopt_array(): Argument #2 ($options) must contain only valid cURL options in /admin/includes/classes/security_checks.php:104 on the same server...

Found out, that the difference to the fresh installed v1.0.8.16 was the php version. With php v7.4 security checks load till death. With php v8.0 the upper Fatal Error appears. Moving all the extended asce_xxx modules out of the extended folder, makes the security checks site appear again. Some hints for the curl options ?

[Denzel]

As CURL_OPTIONS is already an array, I tried this in admin/includes/classes/security_checks.php line 103+104:

Code: Select all

//      $options = array_merge(static::CURL_OPTIONS, $options);
      curl_setopt_array($curl, static::CURL_OPTIONS);

looks good... All checks seem to work... any objections?