Looking for reviews and feedback

[heatherbell]

I am only looking at your site in Finnish because you said you are still working on English.
However, the element in the Footer that has icon fa-question-circle - it shows English, not Finnish.
The same for product_info Tabs for Shipping & Returns - shows English although viewing site in Finnish.
Also, products do not have any Description showing in Product Description Tab.
Some design suggestions:
Give more space between the right NavBar items, that is, between Search, Languages and Cart.
Give space/margin below/between additional images in product_info Gallery, that is, if there are 2 rows of additional images, they are currently touching/have no gap between them.
If it was me, I'd make product_info Tabs a Product Info module to show full width, not a PI module - no need for it to be squeezed on the right.

[Omar_one]

Thank you for your feedback

On your product pages you must have a language define missing as above the product tabs you have all in capitals MODULE_PRODUCT_TAB_SEO_DESCRIPTION_TAB_NAME

fixed it, thank you

On the following product you only have two options listed, but the second one has no option to select. It may be the same on other products but I didnt look. Also in your dropdown lists the text may be better starting with as capital letter. Currently they are all lowercase.

I have QYTPRO module, the I using the dropdown that you have to select first option then the second one will show option, maybe there is an product missing the option hope no , if you can places give the product name ,, so I can check it , the text on dropdown lists I will change it sooner with as capital letter

The continue shopping button on the shopping cart page does not seem to do anything if you remove all the items from the basket. Should it even show in that circumstance.

@raiwa Is there any fix for this issue

The Terms of delivery page is not in English, after clicking the English language at the top of the page. May just be an oversight on your part not to have updated it. The English flag never also changes to any other flag when the language changes.

fixed he Terms of delivery page , still looking for fix for the flag issue
thank you for taking time for test and giving feedback

[Omar_one]

It looks clean and modern.
I like it very much.

thank you @burt to for your feedback , thank you for your hard work and for building a unique shopping cart

1. The index page is showing "Index Page Title | www.hattu.fi". To change this, amend the index.php language file appropriately.

fixed

2. In the product page, you have a ( back ) button under the buy button. I would make this back button less obvious, as with it the same size as the buy button, it distracts from the buy button (hope this makes sense)

the (back) button now smaller ,, the product page need a bit change, thank you

3. You have something missing in the english translations for your tabs in the product page.

fixed ,create new tab and forget to include English file

4. In the footer, two of the box headers (information and headwear info) have a white background - make it grey to match the site.

I added the white background to show more nicer on small screen as it was show the headers as the list of pages, this it can be fixed the adding padding or so

It is our pleasure to hear your valuable feedback.

[Omar_one]

Looks good.

We appreciate you giving us your feedback.

A style you may want to add to your CSS to allow for the arrows to show up in your slideshows for products:

Code: Select all

.carousel-control-prev-icon, .carousel-control-next-icon{
    background-color:#b1b3b4;
    padding: 1em;
    border: 10px solid #b1b3b4;
}

Helps with image blocks like this one: https://www.hattu.fi/ainamuoti-jarmo-va ... th=2_11_75

Of course, change color/style to suit

thank you for the advice , I just add it

[Omar_one]

I am only looking at your site in Finnish because you said you are still working on English.
However, the element in the Footer that has icon fa-question-circle - it shows English, not Finnish.
The same for product_info Tabs for Shipping & Returns - shows English although viewing site in Finnish.
Also, products do not have any Description showing in Product Description Tab.

still a few area to translate, Product Description Tab I just create it for more info about product but still not filled for all the products. I just disable both tabs for now.

Some design suggestions:
Give more space between the right NavBar items, that is, between Search, Languages and Cart.
Give space/margin below/between additional images in product_info Gallery, that is, if there are 2 rows of additional images, they are currently touching/have no gap between them.
If it was me, I'd make product_info Tabs a Product Info module to show full width, not a PI module - no need for it to be squeezed on the right.

I will look to these when I have more time it's look changing the tpl_pi_gallery

Code: Select all

$pi_thumb .= '<div class="row mt-3">';

not helping

Thank you for providing us with valuable feedback. and for your time
Br
Omar

[heatherbell]

it's look changing the tpl_pi_gallery

Code: Select all

$pi_thumb .= '<div class="row mt-3">';

not helping

It is recommended to always add space/margin to bottom of elements.
In this case, add mb-2 to the div class in the tpl file on Line 12
https://github.com/CE-PhoenixCart/Phoen ... ry.php#L12
like:

Code: Select all

$pi_thumb .= '<div class="mb-2 ' . PI_GALLERY_CONTENT_WIDTH_EACH . '">';

Alternatively, go to edit the module in admin and find the configuration for Thumbnail Width.
It will show something like:
col-4 col-sm-6 col-lg-4
change that to:
mb-2 col-4 col-sm-6 col-lg-4

Increase the mb-n to suit yourself.

Thank you for providing us with valuable feedback. and for your time

Afwan sadiqi

[raiwa]

The continue shopping button on the shopping cart page does not seem to do anything if you remove all the items from the basket. Should it even show in that circumstance.

@raiwa Is there any fix for this issue

This has been modified by @ecartz when he revised and added it to Phoenix Pro.
If Matt has no better solution I would remove the action parameter which breaks the code if products have been added and then removed from the card.
In: includes\modules\content\shopping_cart\cm_sc_continue_shopping.php add in line 55:

Code: Select all

        unset($back['get']['action']);

so the whole block looks like this:

Code: Select all

      if( isset($_SERVER['HTTP_REFERER']) && (strpos($_SERVER['HTTP_REFERER'], 'checkout' ) !== false) ) {
        return $link;
      } elseif ($back = $_SESSION['navigation']->path[count($_SESSION['navigation']->path) - 2] ?? false) {
        unset($back['get']['action']);
        return $Linker->build($back['page'], $back['get'] ?? []);
      } else {
        return $link;
      }

This will link to the last visited page, usually the last visited product or category.
Please confirm and I'll update it.

[Omar_one]

This will link to the last visited page, usually the last visited product or category.
Please confirm and I'll update it.

that fix the issue now it's go back to the last visited page

[Omar_one]

https://github.com/CE-PhoenixCart/Phoen ... ry.php#L12
like:

Code: Select all

$pi_thumb .= '<div class="mb-2 ' . PI_GALLERY_CONTENT_WIDTH_EACH . '">';

Afwan sadiqi

I was editing the wrong Div ,, I change mb to my (y - for classes that set both *-top and *-bottom)

Shukran sadiqi

[ecartz]

This has been modified by @ecartz when he revised and added it to Phoenix Pro.

I agree that I made changes to the code here when I added it to Pro. But I don't think that I changed the logic. What do you believe that it used to do that it doesn't do now?

Behavior:

1. If there's anything in the cart, show the category of the item last added to the cart.
2. If nothing in the cart and the last page was a checkout page, show the front page of the shop.
3. If nothing in the cart and the last page was not checkout and there was a page two back in history, show that page.
4. If nothing in the cart, otherwise show the front page of the shop.

As best I can see, this was the behavior before and after my changes.

It looks like the navigation history behavior may have changed. If I'm reading it correctly, there was a period where the only pages added to the navigation history were index_nested and index_products pages. No product_info, etc. Now, it is showing product_info in the navigation history. This was also a change that I made (albeit not intentionally), but it was not at the time of adding Continue Shopping to Pro.