Looking for reviews and feedback

Present your Phoenix to the community and highlight what you've built.
Share design ideas, features, and customizations - and invite constructive feedback if you want it.
raiwa
Certified Developer
Posts: 1640
Joined: Sat Dec 21, 2019 8:08 am
Phoenix Version: 1.1.0.6
Has thanked: 70 times
Been thanked: 152 times

Re: Looking for reviews and feedback

Post by raiwa »

Not sure, I just thought that the change you applied added the action parameter, because I never got this problem reported before. Or maybe it’s due to core changes. Anyway, if you agree with the suggested fix I’ll push it to the Pro repository.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27


Join The Code Co-op to get access to your library in the Code Co-op Forum
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: Looking for reviews and feedback

Post by ecartz »

It's not at all clear to me how navigation history is supposed to work. It's one of those things that predates community edition. I haven't attempted to change how it works, but some of the changes that I made in other code may have had that effect, since one of the things that it does is check the $cPath if it exists.

I actually find it surprising that -2 normally gives a reasonable result. I tried clicking around to break it, but I had no luck on that. Rather than always doing -2 and unsetting the action, it might make more sense to iterate back to the last point where the user was looking at the index page without an action set.

Or just get rid of the whole if/else tree and just return $link -- because it only shows if the shopping cart is empty. And it's not clear what you're continuing at that point anyway. The revised version (unsets the action) shows the last product_info page that you visited. But you just removed that from the cart. Why would you want to go there?
raiwa
Certified Developer
Posts: 1640
Joined: Sat Dec 21, 2019 8:08 am
Phoenix Version: 1.1.0.6
Has thanked: 70 times
Been thanked: 152 times

Re: Looking for reviews and feedback

Post by raiwa »

But you just removed that from the cart. Why would you want to go there?
- Accidentally removed
- Checking again description/image
- Continue in the same category
...
Maybe the alternative could be to link to the category?
Not sure if it's really important. I think it can stay as it is just removing the action so the link works.
Public Phoenix Change Log Cheat Set on Google Sheets
https://docs.google.com/spreadsheets/d/ ... sp=sharing

Need Help?viewtopic.php?f=10&t=27
14Steve14
Senior Contributor
Posts: 920
Joined: Fri Oct 25, 2019 7:01 pm
Phoenix Version: v1.0.9.1
Has thanked: 17 times
Been thanked: 103 times

Re: Looking for reviews and feedback

Post by 14Steve14 »

14Steve14 wrote: Sat Aug 20, 2022 4:00 pm The continue shopping button on the shopping cart page does not seem to do anything if you remove all the items from the basket. Should it even show in that circumstance.
I just wondered when I first mentioned this that may be the button should either return to the last category visited, or even just returns to the index page. Currently the button does nothing if clicked if all products are removed from the cart.
ecartz
Core Team
Posts: 3084
Joined: Tue Nov 05, 2019 6:02 pm
Phoenix Version:
Has thanked: 4 times
Been thanked: 208 times

Re: Looking for reviews and feedback

Post by ecartz »

14Steve14 wrote: Mon Aug 22, 2022 4:26 pm I just wondered when I first mentioned this that may be the button should either return to the last category visited, or even just returns to the index page. Currently the button does nothing if clicked if all products are removed from the cart.
Currently, it goes back to the last product visited. I don't know what it was doing previously. If you're still getting a behavior of it not working, it would be interesting to find out what sequence of events you were following. And what circumstances (browser, OS, etc.). Because I haven't been able to reproduce that on hattu.fi since Rainer's change.
Omar_one
Senior Contributor
Posts: 676
Joined: Fri Oct 25, 2019 5:06 pm
Phoenix Version: v1.0.8.16
Has thanked: 100 times
Been thanked: 56 times

Re: Looking for reviews and feedback

Post by Omar_one »

14Steve14 wrote: Mon Aug 22, 2022 4:26 pm
14Steve14 wrote: Sat Aug 20, 2022 4:00 pm The continue shopping button on the shopping cart page does not seem to do anything if you remove all the items from the basket. Should it even show in that circumstance.
I just wondered when I first mentioned this that may be the button should either return to the last category visited, or even just returns to the index page. Currently the button does nothing if clicked if all products are removed from the cart.
after Rainer's change everything work as it should as @ecartz mentioned
heatherbell
Senior Contributor
Posts: 2540
Joined: Mon Oct 07, 2019 4:39 am
Phoenix Version:
Has thanked: 35 times
Been thanked: 243 times

Re: Looking for reviews and feedback

Post by heatherbell »

Omar_one wrote: Sat Aug 20, 2022 11:05 am Omar
A "must have" for every site, IMO, is:

Code: Select all

.carousel-indicators li {
background-color: #575757 !important;
}
.carousel-indicators {
bottom:-50px;
}
.carousel-inner {
    margin-bottom:50px;
 }
 
lecarlb
Contributor
Posts: 316
Joined: Mon Oct 26, 2020 5:26 pm
Phoenix Version:
Has thanked: 48 times
Been thanked: 9 times

Re: Looking for reviews and feedback

Post by lecarlb »

Overall I love the modern design and scheme. The images of the people you used to model made it feel like you will see them at the grocery store or at a hometown gathering. Very inviting. Great choice going with the pill buttons.

In my opinion, the only thing I would change is there is too much color in the box with the payment methods. But that doesn't take away from the overall attractiveness. You have a great site! A lot better than mine lol
Omar_one
Senior Contributor
Posts: 676
Joined: Fri Oct 25, 2019 5:06 pm
Phoenix Version: v1.0.8.16
Has thanked: 100 times
Been thanked: 56 times

Re: Looking for reviews and feedback

Post by Omar_one »

lecarlb wrote: Wed Aug 31, 2022 4:40 pm Overall I love the modern design and scheme. The images of the people you used to model made it feel like you will see them at the grocery store or at a hometown gathering. Very inviting. Great choice going with the pill buttons.

In my opinion, the only thing I would change is there is too much color in the box with the payment methods. But that doesn't take away from the overall attractiveness. You have a great site! A lot better than mine lol
thank you @lecarlb for your feedback,
lecarlb wrote: Wed Aug 31, 2022 4:40 pm In my opinion, the only thing I would change is there is too much color in the box with the payment methods.
thank you , just to be more clear for customers what banks included our payment.
lecarlb wrote: Wed Aug 31, 2022 4:40 pm A lot better than mine lol
I am sure you can have better ,,, just you need to play with it , if you want to ask anything about our shop, I will be more then happy to answer you.

Br
Omar
lecarlb
Contributor
Posts: 316
Joined: Mon Oct 26, 2020 5:26 pm
Phoenix Version:
Has thanked: 48 times
Been thanked: 9 times

Re: Looking for reviews and feedback

Post by lecarlb »

Hello @Omar_one,

What did you use the give the search box a pill shape?

Thanks.


Join The Code Co-op to get access to your library in the Code Co-op Forum
Post Reply