User Name Stays on NavBar after Logging Out

[Moxamint]

Possible core change in the navbar module:
includes\modules\navbar\nb_account.php line 20:

Code: Select all

      if ( ($GLOBALS['customer'] ?? null) instanceof customer && isset($_SESSION['customer_id']) ) {

This works as well.

[Kofod95]

[...] but how come you know exactly when the lunar new year will be?

We recently received the Davidoff and the Macanudo cigars celebrating the arrival of the Year of the Rabbit, so when I created the products, I did some reading

//Daniel

[raiwa]

Possible core change in the navbar module:
includes\modules\navbar\nb_account.php line 20:

Code: Select all

      if ( ($GLOBALS['customer'] ?? null) instanceof customer && isset($_SESSION['customer_id']) ) {

@ecartz Could this go into 1.0.8.21/1.0.9.0?

[ecartz]

@ecartz Could this go into 1.0.8.21/1.0.9.0?

Try: save

Code: Select all

<?php
/*
  $Id$
  CE Phoenix, E-Commerce made Easy
  https://phoenixcart.org
  Copyright (c) 2023 Phoenix Cart
  Released under the GNU General Public License
*/

  class global_eraser {

    public function __call($name, $arguments) {
      unset($GLOBALS[$name]);
    }

  }

at includes/classes/magic/global_eraser.php and add

Code: Select all

INSERT INTO hooks (hooks_site, hooks_group, hooks_action, hooks_code, hooks_class, hooks_method) VALUES ('shop', 'logoff', 'resetStart', '_41_unset_customer', 'global_eraser', 'customer');

My test shop is down, so I can't test/try anything until I build a replacement. But I'd prefer not to change the logic, if customer, then do stuff with customer. I'd rather change whether or not the customer object exists. That will also be more robust in other features with the same logic.

[raiwa]

@ecartz Could this go into 1.0.8.21/1.0.9.0?

Try: save

Code: Select all

<?php
/*
  $Id$
  CE Phoenix, E-Commerce made Easy
  https://phoenixcart.org
  Copyright (c) 2023 Phoenix Cart
  Released under the GNU General Public License
*/

  class global_eraser {

    public function __call($name, $arguments) {
      unset($GLOBALS[$name]);
    }

  }

at includes/classes/magic/global_eraser.php and add

Code: Select all

INSERT INTO hooks (hooks_site, hooks_group, hooks_action, hooks_code, hooks_class, hooks_method) VALUES ('shop', 'logoff', 'resetStart', '_41_unset_customer', 'global_eraser', 'customer');

My test shop is down, so I can't test/try anything until I build a replacement. But I'd prefer not to change the logic, if customer, then do stuff with customer. I'd rather change whether or not the customer object exists. That will also be more robust in other features with the same logic.

Confirmed. Works like expected.

Thank you very much and a Happy New Year
Rainer