1.0.8.20 Questions / Comments / Concerns

[burt]

Would it be possible to show an ‘enabled’ column on all the Modules pages?

admin/modules.php

add

Code: Select all

[
'name' => TABLE_HEADING_ENABLED,
'class' => 'text-right',
'is_heading' => false,
'function' => function ($row) {
return ($row['enabled'] > 0)
? '<i class="fas fa-check-circle text-success"></i>'
: '<i class="fas fa-times-circle text-danger"></i>';
},
],

It should be fairly obvious where to add it.
Pls report back if it works (and that it causes no unintended consequences).

[Brighton]

Thank you, that appears to be exactly what was wanted. It displays the ‘Enabled’ column on all the Modules pages. A couple of things to note -

To place the column in the same relative position as on the Content modules page,
modules.php line 63 array_splice($table_definition['columns'], -1, 0, [
change the –1 to –2

Your suggestion was added after line 44 in modules.php

includes/modules/cfg_modules/cfgm_content.php
to suppress the existing ‘Enabled’ column showing as a duplicate on the Content modules page
comment out lines 72 – 84

includes/modules/cfg_modules/cfgm_layout.php
to suppress the existing ‘Enabled’ column showing as a duplicate on the Layout modules page
comment out lines 144 – 154

Sorry for the late reply, I hadn’t noticed this second page.

[burt]

Did anyone else try the changes as detailed in the two posts above [my post and Brighton post]?
Would it be a useful change in the next version of Phoenix ?

[heatherbell]

Did anyone else try the changes as detailed in the two posts above [my post and Brighton post]?

Yes. Confirmed that those changes result in expected behaviour.

Would it be a useful change in the next version of Phoenix ?

Definitely because the behaviour before changes is unexpected.

[Kofod95]

I second heatherbell on the post above. The change makes unexpected behavior into expected behavior in my view. Thank you for the code and for looking into it!

//Daniel

[burt]

If I can get Sourcetree up and running I'll make a branch this week with some minor changes for Matts approval/pull. Thanks Chaps.