PHP 8.2 - Community Input

[Omar_one]

Code: Select all

PHP Deprecated:  Creation of dynamic property wishlist::$listID is deprecated in /home/shop/public_html/includes/system/versioned/1.0.8.3/session.php on line 55

lines 55-57 I think this error caused from wishlist module

Code: Select all

  static::$started = session_start();
      return static::$started;
    }

Code: Select all

PHP Deprecated:  Creation of dynamic property paypal_standard::$signature is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 39
PHP Deprecated:  Creation of dynamic property paypal_standard::$api_version is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 40
PHP Deprecated:  Creation of dynamic property paypal_standard::$public_title is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 43
PHP Deprecated:  Creation of dynamic property paypal_standard::$sort_order is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 47
PHP Deprecated:  Creation of dynamic property paypal_standard::$order_status is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 49
PHP Deprecated:  Creation of dynamic property paypal_standard::$form_action_url is deprecated in /home/shop/public_html/includes/modules/payment/paypal_standard.php on line 58

lines 39-61

Code: Select all

$this->signature = 'paypal|paypal_standard|' . $this->_app->getVersion() . '|2.3';
      $this->api_version = $this->_app->getApiVersion();

      $this->title = $this->_app->getDef('module_ps_title');
      $this->public_title = $this->_app->getDef('module_ps_public_title');
      if (isset($GLOBALS['Admin'])) {
        $this->description = '<div align="center">' . $this->_app->drawButton($this->_app->getDef('module_ps_legacy_admin_app_button'), $GLOBALS['Admin']->link('paypal.php', 'action=configure&module=PS'), 'primary', null, true) . '</div>';
      }
      $this->sort_order = defined('OSCOM_APP_PAYPAL_PS_SORT_ORDER') ? OSCOM_APP_PAYPAL_PS_SORT_ORDER : 0;
      $this->enabled = defined('OSCOM_APP_PAYPAL_PS_STATUS') && in_array(OSCOM_APP_PAYPAL_PS_STATUS, ['1', '0']);
      $this->order_status = defined('OSCOM_APP_PAYPAL_PS_PREPARE_ORDER_STATUS_ID') && ((int)OSCOM_APP_PAYPAL_PS_PREPARE_ORDER_STATUS_ID > 0) ? (int)OSCOM_APP_PAYPAL_PS_PREPARE_ORDER_STATUS_ID : 0;

      if ( defined('OSCOM_APP_PAYPAL_PS_STATUS') ) {
        if ( OSCOM_APP_PAYPAL_PS_STATUS == '0' ) {
          $this->title .= ' [Sandbox]';
          $this->public_title .= ' (' . $this->code . '; Sandbox)';
        }

        if ( OSCOM_APP_PAYPAL_PS_STATUS == '1' ) {
          $this->form_action_url = 'https://www.paypal.com/cgi-bin/webscr';
        } else {
          $this->form_action_url = 'https://www.sandbox.paypal.com/cgi-bin/webscr';
        }

Code: Select all

PHP Deprecated:  substr(): Passing null to parameter #1 ($string) of type string is deprecated in /home/shop/public_html/includes/apps/paypal/OSCOM_PayPal.php on line 182

lines 180-191

Code: Select all

if ( $type == 'email') {
        $creds = ['OSCOM_APP_PAYPAL_' . $server . '_SELLER_EMAIL'];
      } elseif ( substr($type, 0, 7) == 'payflow' ) {
        if ( strlen($type) > 7 ) {
          $creds = ['OSCOM_APP_PAYPAL_PF_' . $server . '_' . strtoupper(substr($type, 8))];
        } else {
          $creds = [
            'OSCOM_APP_PAYPAL_PF_' . $server . '_VENDOR',
            'OSCOM_APP_PAYPAL_PF_' . $server . '_PASSWORD',
            'OSCOM_APP_PAYPAL_PF_' . $server . '_PARTNER',
          ];
        }

[ecartz]

Code: Select all

PHP Deprecated:  Creation of dynamic property wishlist::$listID is deprecated in /home/shop/public_html/includes/system/versioned/1.0.8.3/session.php on line 55

lines 55-57 I think this error caused from wishlist module

Code: Select all

  static::$started = session_start();
      return static::$started;
    }

Nope. That would cause a message about Session::$started (if not previously declared, but it is at https://github.com/CE-PhoenixCart/Phoen ... on.php#L15 ). That message is about wishlist::$listID. Try line 65 of includes/system/versioned/1.0.7.other/1.0.7.12/wishlist.php. Note that it's not clear to me if it needs to be declared or if line 65 should be wishlistID which is already declared.

[Omar_one]

here is the line 64-66 from includes/system/versioned/1.0.7.other/1.0.7.12/wishlist.php.

Code: Select all

// assign a temporary unique ID to the order contents to prevent hack attempts during the checkout procedure
      $this->listID = $this->generate_list_id();
    }