1.0.9.1 Questions / Comments / Concerns

[burt]

Update instructions (from 1.0.9.0):
https://github.com/CE-PhoenixCart/Updat ... /README.md

Release:
https://github.com/CE-PhoenixCart/Phoen ... g/v1.0.9.1

This is the 1.0.9.1 release which removes legacy code and functions.

Thank you to all supporters of the Project who allow Phoenix to fly higher and burn brighter.

[bonbec]

Thanks !

The includes/version.php with the right version number is missing in the update.zip

[heatherbell]

The includes/version.php with the right version number is missing

After updating, ensure to edit your file, /includes/version.php
Change 1.0.9.0 to 1.0.9.1

[bonbec]

Hello @heatherbell
Thanks but that's what I did.
It makes more sense to provide the file in question in update.zip

[raiwa]

In: includes\system\versioned\1.0.7.other\1.0.7.12\guarantor.php
These 2 functions should probably also bee removed:

Code: Select all

  function &tep_guarantee_subarray(&$data, $key) {
    trigger_error('The tep_guarantee_subarray function has been deprecated.', E_USER_DEPRECATED);
    return Guarantor::guarantee_subarray($data, $key);
  }

  function &tep_guarantee_all(&$data, ...$keys) {
    trigger_error('The tep_guarantee_all function has been deprecated.', E_USER_DEPRECATED);
    return Guarantor::guarantee_all($data, $keys);
  }

[zipurman]

When editing or adding new Customer Data Groups, the class is being set to "12" where it should be "col-12", as a result, the layout breaks.

[zipurman]

When editing or adding new Customer Data Groups, the class is being set to "12" where it should be "col-12", as a result, the layout breaks.

Looks like the issue is in the admin, where it is saving the class as 12 rather than col-sm-12.

[burt]

I cannot recreate this...
It saves as whatever I input into the box.

I do notice that when adding a new group, a value of 12 is inserted into the box, which should be changed to eg col-sm-12. I'll fix that in 1.0.9.2 - thanks for noticing.

[burt]

https://github.com/CE-PhoenixCart/Phoen ... bf971191ef
TY

[zipurman]

I cannot recreate this...
It saves as whatever I input into the box.

A fresh install has all set to 12. Also, as you mentioned, any new entries also were defaulted to 12 instead of col-sm-12