s06e02 - XML Sitemaps SUPPORT / QUESTIONS

[heatherbell]

just upgraded my store to v1.9.1

Maybe you have not upgraded the addon.
There are no tep_draw_bootstrap_button functions in the current package:
viewtopic.php?p=7798#p7798

[kudos]

strange, i pulled files from the Pro package upgrade,
but the one you linked to, reuploaded all files and working no more errors now

thanks

[rupruprup]

PHP Fatal error: Uncaught Error: Call to undefined method DOMDocument::setAttributeNode() in /includes/system/override/gb/xml_writer.php:79

on 1.0.9.4

[burt]

PHP Fatal error: Uncaught Error: Call to undefined method DOMDocument::setAttributeNode() in /includes/system/override/gb/xml_writer.php:79

on 1.0.9.4

I have just tested on my 1.0.9.5 and it seemed to work without problems.
Download for correct version? app.php/tag/s06e02

[rupruprup]

reinstalled it and now it works with the same version, anyway thanks for caring

[14Steve14]

We have just checked the validity of our site maps and are getting a error that the priotity is invalid. It only happens on one validator.

It is saying that rather than

<priority>1</priority>

it should be
<priority>1.0</priority>

Is there a way of changing this. In includes/system/override/gb/xml_writer.php I tried to change

Code: Select all

$priority = 1;

to 1.0 but nothing changed.

Is the change really required and if so how to make the change.

[heatherbell]

Is the change really required and if so how to make the change.

Technically, the sitemap priority element should use a decimal format. The priority values are intended to be between 0.0 and 1.0, so some validators may flag integers like 1 as invalid.
Try (untested):

Code: Select all

$priority = number_format(1.0, 1);

which should enforce the 1 decimal place format.

[14Steve14]

Is the change really required and if so how to make the change.

Technically, the sitemap priority element should use a decimal format. The priority values are intended to be between 0.0 and 1.0, so some validators may flag integers like 1 as invalid.
Try (untested):

Code: Select all

$priority = number_format(1.0, 1);

which should enforce the 1 decimal place format.

Thanks for the help.

No difference after the change so I asked AI and changed the following

Code: Select all

          $el4 = $doc->createElement('priority');
          $el4->nodeValue = 1;
          $item->appendChild($el4);

to

Code: Select all

          $el4 = $doc->createElement('priority');
          $el4->nodeValue = sprintf("%.1f", $priority); // Ensures priority is displayed as '1.0'
          $item->appendChild($el4);

Whether both changes were required, or whether this is the best way to achieve this, I don't know but now everything shows correctly in all the xml sitemaps.

[burt]

$el4->nodeValue = '1.0';

Might do it, which (if it works) would be the most simple way.
This changes the value to a `string = 1.0` rather than an `integer = 1`

[mhsuffolk]

$el4->nodeValue = '1.0';

Might do it, which (if it works) would be the most simple way.
This changes the value to a `string = 1.0` rather than an `integer = 1`

Yes I can confirm this works on 1.0.9.0. Produces this in the XML

Code: Select all

<priority>1.0</priority>