1.0.9.5 Questions / Comments / Concerns

[burt]

1.0.9.5 continues the optimisations (and typo fixes and bug fixes) made in the previous couple of versions. Although 1.09.5 is on the pathway to updating Phoenix to Bootstrap 5, it is still Bootstrap 4 based.

There are many small optimisations, fixes and changes. We have tried our best to remove as much jQuery as we could, also to solve as many "dev tool" issues as we could and to try to make Phoenix "tighter" in terms of look and style, whilst also making Phoenix more flexible without having to delve into code.

Interesting new features;

1. Contact Us page is now modular and PI layout enabled (I believe these new modules came from a community effort within these forums, TY to all who were involved in that).
2. Product Card buttons can be turned on and off from within Admin (TY Matt ecartz)
3. Define Language page has been (at last!) removed from Phoenix
4. Create Account page is laid out slightly differently (hopefully nicer to look at)
5. Shopping Cart page is laid out slightly differently (hopefully easier to "tap target")
6. Tax ID can now be input via Admin, and shows in Footer of page and on Invoices
7. Admin Product Attributes page is laid out slightly differently, hopefully it is easier to use

Potential Breaking Changes;

A. Product Card data-attributes have been moved to the containing DIV, away from the buy button. See Item #2 above for the reason why this was done. I know this will break at least two PRO addons. These will be fixed and re-released asap.

--

If you have time, please to install a test shop and have a play.
Feel free to give your thoughts and any feedback/advice.

Zip for download
https://github.com/CE-PhoenixCart/Phoen ... .0.9.5.zip

TY in advance.

[burt]

I will make a .zip of all the changed files etc either today or tomorrow, to try to ease upgrading.

Once done I will post the .zip in this thread.

[burt]

To go from 1.0.9.4 to 1.0.9.5, you may try these instructions. Any and all feedback on these instructions would be appreciated please so that I can then make them public.

SQL:

Note that these are only the SQL changes that will break your site if not run.
There are others, but they are only cosmetic.

Code: Select all

INSERT INTO configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) VALUES ('Store Tax ID', 'STORE_TAX_ID', '', 'This is the Tax ID of my business.', 1, 19, NOW());

INSERT INTO configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) VALUES ('Display buttons in product listing', 'PRODUCT_LIST_BUTTONS', 'False', 'Do you want to display buy and view buttons in the product listing', 8, 290, 'Config::select_one([\'True\', \'False\'], ', NOW());

INSERT INTO hooks (hooks_site, hooks_group, hooks_action, hooks_code, hooks_class, hooks_method) VALUES ('shop', 'siteWide', 'injectProductCard', '_10_inject_product_card', '', 'product_card::inject');

INSERT INTO configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Background Colour', 'MODULE_HEADER_TAGS_TABLE_CLICK_JQUERY_TR_BACKGROUND', 'table-success', 'The background colour of the clicked Row.  See https://getbootstrap.com/docs/4.6/content/tables/#contextual-classes', 6, 3, now());

ZIP:

Update to 1.0.9.5.zip

THEN:

Install Content Modules & Layout Modules for Contact Us page.

[frankl]

Incorrect database password gives a silent fail (page hangs with never ending spinner)

error_log shows

PHP Fatal error: Uncaught mysqli_sql_exception: Access denied for user 'database_user'@'localhost' to database 'server_database' in /home/server/public_html/install/rpc.php:30
Stack trace:
#0 /home/server/public_html/install/rpc.php(30): mysqli->select_db('server_database')
#1 {main}
thrown in /home/server/public_html/install/rpc.php on line 30

[frankl]

PHP Fatal error: Uncaught mysqli_sql_exception: Specified key was too long; max key length is 1000 bytes in /home/server/public_html/includes/system/versioned/1.0.8.9/sql_file.php:45
Stack trace:
#0 /home/server/public_html/includes/system/versioned/1.0.8.9/sql_file.php(45): mysqli->next_result()
#1 /home/server/public_html/includes/system/versioned/1.0.8.9/sql_file.php(86): sql_file->run_sql('# $Id$\n#\n# CE P...')
#2 /home/server/public_html/install/includes/classes/installer.php(64): sql_file->install()
#3 /home/server/public_html/install/rpc.php(82): Installer::load_sql(Object(Database), '/home/server/...')
#4 {main}
thrown in /home/server/public_html/includes/system/versioned/1.0.8.9/sql_file.php on line 45

Obviously this is because I am running MySQL 5.7.4 - but perhaps make checking MySQL version before attempting to import sql file? Not sure if many people would be running such an old version?

In any case changing all instances of CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; to CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; in install/phoenix.sql allowed importing into a MySQL 5.7.4 database

[burt]

TY, the issue with the hanging install has been noticed previously, no one has yet had time to look at it.

I think that whole part is broken, as that part should also deal with `mysql version too low`.

[raiwa]

Updated an 1.0.9.4 store and get this error when trying to install the contact_us layout modules:

Code: Select all

Fatal error: Uncaught Error: Undefined constant "MODULE_CONTENT_CU_INSTALLED" in C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\modules\cfg_modules\cfgm_layout.php:80 Stack trace: #0 C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\modules\cfg_modules\cfgm_layout.php(80): constant('MODULE_CONTENT_...') #1 C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\classes\cfg_modules.php(66): cfgm_layout::fix_installed_constant(Array) #2 C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\actions\modules\install.php(29): cfg_modules->fix_installed_constant('layout', Array) #3 C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\segments\process_action.php(19): require('C:\\laragon\\www\\...') #4 C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\modules.php(50): require('C:\\laragon\\www\\...') #5 {main} thrown in C:\laragon\www\xxxxxxxxxxxxxxxxxxxx\admin\includes\modules\cfg_modules\cfgm_layout.php on line 80

EDIT: Got it. Need to install the pi content module first.
This should be included in the update instructions.

[raiwa]

In: admin\includes\languages\english\configuration.php line 13 has been added:

Code: Select all

const HEADING_TITLE = 'Configuration';

But it seems not to be used anywhere,
Searched in the main file and all actions.

[burt]

EDIT: Got it. Need to install the pi content module first.
This should be included in the update instructions.

THEN:

Install Content Modules & Layout Modules for Contact Us page.

[burt]

In: admin\includes\languages\english\configuration.php line 13 has been added:

Code: Select all

const HEADING_TITLE = 'Configuration';

But it seems not to be used anywhere,
Searched in the main file and all actions.

I believe this is used in Admin area.