Re: S04e08 - Canned order comments

[radhavallabh]

Addon:
Allows shopowner to set up Stored Comments to save the extra time continually typing them out order by order.

Download:
viewtopic.php?f=28&t=1066


--

For 1.0.8.5 and newer: S04e08-1.0.8.5.zip

Hi dear;
I am getting error on canned_comments.php
Notice
: Trying to access array offset on value of type null in /xx/admin/includes/actions/canned_comments/infoboxes/default.php
on line
27
on below line

Code: Select all

$text .= '<br>' . $GLOBALS['Admin']->catalog_image("includes/languages/{$l['directory']}/images/{$l['image']}", [], $l['name']) . '&nbsp;' . $comment_text['orders_comments_text'];

Please can you help me fix the issue;
Warm Regds./
radhavallabh

[ecartz]

You could try changing that line to

Code: Select all

      $text .= '<br>' . $GLOBALS['Admin']->catalog_image("includes/languages/{$l['directory']}/images/{$l['image']}", [], $l['name']) . '&nbsp;'
 . ($comment_text['orders_comments_text'] ?? '');

But a better solution would be to fix whatever is causing the database query to fail.

[radhavallabh]

You could try changing that line to

Code: Select all

      $text .= '<br>' . $GLOBALS['Admin']->catalog_image("includes/languages/{$l['directory']}/images/{$l['image']}", [], $l['name']) . '&nbsp;'
 . ($comment_text['orders_comments_text'] ?? '');

But a better solution would be to fix whatever is causing the database query to fail.

Dear.. how to check that why the database query fails...
Please can you elaborate so I could debug more...

Thank you in advance;
Very Warm Regds.
radhavallabh

[radhavallabh]

Hi dear ;
One more issue, I tested on fresh install of 1.0.8.14 before reporting-
I installed 4 languages.

1. I tried inserting a new Canned order comment on canned_comments.php;
2. I clicked edit it shows all 4 languages;
3. On clicking save-
It saves the comment in English only rest all languages are wiped out blank automatically.

Please can you help resolve this issue;
Thank you in advance;
Regds./
radhavallabh

[radhavallabh]

Hi dear ;
One more issue, I tested on fresh install of 1.0.8.14 before reporting-
I installed 4 languages.

1. When I tried inserting a new Canned order comment on canned_comments.php it displays all 4 languages but does not save the information to all 4 of them , saves only to english;
2. Or when I clicked edit it shows all 4 languages but only engilsh field is filled with data rest are empty;
3. On clicking save-
It saves the comment in English only rest all languages are wiped out blank automatically.

Hi dear @ecartz please can you help fix this issue....
Thank you in advance;
Very Warm Regds./
radhavallabh

[ecartz]

Have you asked @Kofod95 if he gets the same behavior?

Can you get the same results with just two languages?

Did this work in 1.0.8.0?

[radhavallabh]

Have you asked @Kofod95 if he gets the same behavior?

Can you get the same results with just two languages?

Did this work in 1.0.8.0?

Yes it was working up to 1.0.8.0 as I have previously saved entries in all 4 languages. (That to on a modified pro store)

But now when I tried to add a new canned comment in the same upgraded 1.0.8.14 store and a default 1.0.8.14 test install it just saves it in English.
I have not asked @Kofod95 yet dear.
Hope @Kofod95 dear could help us test the same too.

Thank you in advance;
Warm Regds./
radhavallabh

[Kofod95]

Will try next time I'm at my PC - might be a while as I'm away most of the weekend

//Daniel

[Omar_one]

Hi dear ;
One more issue, I tested on fresh install of 1.0.8.14 before reporting-
I installed 4 languages.

1. I tried inserting a new Canned order comment on canned_comments.php;
2. I clicked edit it shows all 4 languages;
3. On clicking save-
It saves the comment in English only rest all languages are wiped out blank automatically.

Please can you help resolve this issue;
Thank you in advance;
Regds./
radhavallabh

@ecartz I just try it on 1.0.8.14 (updated version) have same issue just the English only input shows. I checked the phpMyAdmin the tables are there and both languages entry there ,
so the admin-canned_comments.php shows just one language

[ecartz]

Hi dear @ecartz please can you help fix this issue....

I updated the zip.