S04e12-Responsible Social Bookmarks QUESTIONS/SUPPORT

[burt]

Yes, I think so. "X" was introduced in 6.4.2 so you'd need to be on at least that for it to show.

[14Steve14]

Do we need to update the fontawesome cdn link to 6.5.1 as I can only find the x-twitter icon in that version on the fontawesome site?

For now I have just used 'fas fa-times-circle'

[tessthepup]

Yes, I think so. "X" was introduced in 6.4.2 so you'd need to be on at least that for it to show.

@burt

I have updated to the latest version of Fontawesome and touch would nothing has broken (at least nothing that I have found)

I have rewrote the module template to have the text and icons on the same row

Code: Select all

<div class="col-sm-<?= (int)PI_RESPONSIBLE_SOCIAL_BOOKMARKS_CONTENT_WIDTH ?> socialMediaLinks mt-4 mb-2">
 <div class="row d-flex justify-content-center">
  <div><h3><?= PI_RESPONSIBLE_SOCIAL_BOOKMARKS_PUBLIC_TITLE ?></h3></div>
  <div><?= implode('', $pi_sb_bookmarks) ?></div>
 </div> 
</div>

and also the CSS to suit

Code: Select all

.socialMediaLinks i {
    font-size: 1.9em;  
    margin: 0 10px 0 0;
    color: #c6c3c2;
    text-decoration: none;
}

.socialMediaLinks i.fa-x-twitter { 
    color: #00aced;
}
.socialMediaLinks i.fa-facebook { 
    color: #3b5998; 
}
.socialMediaLinks i.fa-pinterest { 
    color: #C92228; 
}

The only thing I can not get to work is have the text center aligned with the icons.

I have tried align-self-center but that does not work

Any ideas please???

Thanks

[burt]

More or less, remember this...

Horizontal uses justify [ https://getbootstrap.com/docs/4.6/utili ... fy-content ]
Vertical uses align [ https://getbootstrap.com/docs/4.6/utili ... lign-items ]

Therefore, something like this should work;

Code: Select all

<div class="row d-flex justify-content-center align-items-center">

Though I have not tested it.

Also;
You should not need that <div around your <h3
You should not need that <div around the bookmarks

This looks like it should work;

Code: Select all

<div class="col-sm-<?= (int)PI_RESPONSIBLE_SOCIAL_BOOKMARKS_CONTENT_WIDTH ?> socialMediaLinks mt-4 mb-2">
 <div class="row d-flex justify-content-center align-items-center">
  <h3><?= PI_RESPONSIBLE_SOCIAL_BOOKMARKS_PUBLIC_TITLE ?></h3>
  <?= implode('', $pi_sb_bookmarks) ?>
 </div> 
</div>

[tessthepup]

More or less, remember this...

Horizontal uses justify [ https://getbootstrap.com/docs/4.6/utili ... fy-content ]
Vertical uses align [ https://getbootstrap.com/docs/4.6/utili ... lign-items ]

Therefore, something like this should work;

Code: Select all

<div class="row d-flex justify-content-center align-items-center">

Though I have not tested it.

Also;
You should not need that <div around your <h3
You should not need that <div around the bookmarks

This looks like it should work;

Code: Select all

<div class="col-sm-<?= (int)PI_RESPONSIBLE_SOCIAL_BOOKMARKS_CONTENT_WIDTH ?> socialMediaLinks mt-4 mb-2">
 <div class="row d-flex justify-content-center align-items-center">
  <h3><?= PI_RESPONSIBLE_SOCIAL_BOOKMARKS_PUBLIC_TITLE ?></h3>
  <?= implode('', $pi_sb_bookmarks) ?>
 </div> 
</div>

@burt

Thanks Gary, I have removed the <div>'s but align-items-center did not work until I added

Code: Select all

height: 40px;

to the css

[lecarlb]

@burt or anyone

I uploaded on a 1.0.8.20 site and there is an issue:

• The Twitter "X" button doesn't show in the PI module

This is the only error I found in error logs related to this:

Code: Select all

[Mon Apr 01 05:48:17.523786 2024] [proxy_fcgi:error] [pid 4154209:tid 139701235205696] [client 173.190.176.123:0] AH01071: Got error 'PHP message: PHP Deprecated:  The tep_href_link function has been deprecated. in /var/www/vhosts/xxxxxxxxxx.com/httpdocs/adminBTDC1/includes/functions/html_output.php on line 51PHP message: PHP Deprecated:  The tep_href_link function has been deprecated. in /var/www/vhosts/xxxxxxxxxx.com/httpdocs/adminBTDC1/includes/functions/html_output.php on line 51PHP 
 message: PHP Deprecated:  The tep_href_link function has been deprecated. in /var/www/vhosts/xxxxxxxxxx.com/httpdocs/adminBTDC1/includes/functions/html_output.php on line 51PHP 
 message: PHP Deprecated:  The tep_href_link function has been deprecated. in /var/www/vhosts/xxxxxxxxxx.com/httpdocs/adminBTDC1/includes/functions/html_output.php on line 51', referer: https://xxxxxxxxxx.com/adminBTDC1/modules.php?set=layout

What should I check?

Thank you.

[heatherbell]

The Twitter "X" button doesn't show in the PI module
What should I check?

As answered in previous posts:
"X" was introduced in 6.4.2 so you'd need to be on at least that for it to show.
https://github.com/CE-PhoenixCart/Phoen ... wesome.php

The tep_href_link function has been deprecated.

The notice does not seem to be related to this addon.

[lecarlb]

As answered in previous posts:
"X" was introduced in 6.4.2 so you'd need to be on at least that for it to show.
https://github.com/CE-PhoenixCart/Phoen ... wesome.php

After updating that file, still no show.

Thank you.

[lecarlb]

Still no luck

The button works but it's invisible.

[heatherbell]

The button works but it's invisible.

Tested and works fine as shown here https://phoenixcart.org/PROdemo/product ... ducts_id=6
If you updated from previous version of the addon, double check that user.css is updated the same as detailed in the README.