s06e02 - XML Sitemaps SUPPORT / QUESTIONS

[14Steve14]

No idea why this is happening but when I use Gary's suggestion it shows 1.0 in all the xml files.

When I use my code all files show 1.0 apart from the categories sitemap which shows 0.5. I am aware that the standard core code should be 0.5 for this file, but for some reason it shows as 1.0 rather than 0.5.

I tried uploading the file from 1.0.9.0. pro and the categories file still showed 1.0 without the update. Looking through previous backups going back months the categories xml file was always showing 1.0.

[frankl]

Can't seem to get it to work on 1.1.0.4

It keeps looking for 'default' action rather than 'renew_XML' action.

Also, lastmod format can be Y-m-d format rather than 'c' format according to Google specs (although I don't think it makes a boig difference)

https://developers.google.com/search/do ... 774934#xml

[burt]

Is admin/index.php processing actions ?
https://github.com/CE-PhoenixCart/Phoen ... 7410568951

[frankl]

Is admin/index.php processing actions ?
https://github.com/CE-PhoenixCart/Phoen ... 7410568951

Correct

[burt]

I think always_valid_actions rears its ugly head again :-\

/includes/hooks/admin/index/XML_Writer.php

add a new function;

Code: Select all

  public function listen_preAction() {
    $GLOBALS['always_valid_actions'] ??= [];
    $GLOBALS['always_valid_actions'][] = 'renew_XML';
  }

Untested, but looks like it might do it.
Pls report back @frankl TY

[BatteryTrader]

Hi

Have 1.1.0.3

The Sitemaps are created as expected but the categories canonical on the site has ?view=all after the address, which as i understand it, is correct, and resolves the pagination issue. But in the site map this is missing, I assume I can add ?view=all somewhere to prepend the html address in the xml sitmaps, but not sure where yet. pointer anyone?

Regards

David

[burt]

The category site map should be a link to each category (for example)

yourshop.com/index.php?cPath=3
yourshop.com/index.php?cPath=3_4
yourshop.com/index.php?cPath=3_4_5

NO "view_all" is, I think, correct...

Take this particular one;

yourshop.com/index.php?cPath=3_4_5

let's say it has 60 products, so it has paging.

yourshop.com/index.php?cPath=3_4_5
yourshop.com/index.php?cPath=3_4_5&page=2
yourshop.com/index.php?cPath=3_4_5&page=3

Instead of this you want &view=all, which is what the Canonical Header Tag does.

I think that everything seems correct;

1. No view=all in the sitemap
2. view=all in the header tag

I am happy to be corrected by anyone who knows better.

[BatteryTrader]

I would have thought that the canonical should match the sitemap, at least I believe that's what Google asks for, else it becomes a duplicate without a user-selected canonical.

I also would like to be corrected if i am wrong.

Regards

[radhavallabh]

Hi,
Using 1.1.0.6 , php 7.4;
On clicking renew XML files dashboard- this URL of admin section- xx.com/admin/index.php?action=renew_XML ;
The files do not update at all... no error in php

Also when I click on view files the main page just refreshes


Please can you help..
Thank you in advance;
Warm Regds./
radhavallabh

[burt]

First, please try this change, and post back if it works;

viewtopic.php?p=20793#p20793