1.1.0.3 Questions / Comments / Concerns / Feedback

[raiwa]

Very small issue, probably introduced in a previous version in:
includes\languages\english\modules\navbar\nb_search.php line 16:

Code: Select all

  const MODULE_NAVBAR_SEARCH_PUBLIC_TEXT = '<i title="Search our site" class="fas fa-magnifying-glass fa-fw fa-xl"></i><span class="ps-1">Product Search</span>';

Uses: "Search our site" as i title, but "Product Search" as visible Placeholder.

[frankl]

When adding extra gallery images for products:

Warning: Undefined array key "sort_order_new_1" in /includes/actions/catalog/update_product.php on line 78

Warning: Undefined array key "sort_order_new_2" in /includes/actions/catalog/update_product.php on line 78

[burt]

When adding extra gallery images for products

https://github.com/CE-PhoenixCart/Phoen ... 91e1fa5d48

[burt]

Testing local and online update from 1.1.0.2 created an account and immediately tried to delete it, expressly entered the wrong password and I would expect to get the message that your password is incorrect, but that does not happen I have changed in /ext/modules/content/account/nuke_account.php at nuke add_session to add and that works, now I get the message that the password is incorrect

https://github.com/CE-PhoenixCart/Phoen ... 65500ecc56

[frankl]

I have only imported customers, no new customers who have agreed to any terms, conditions etc.

customers_gdpr table is of course empty

PHP Warning: Undefined array key "privacy" in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 37
PHP Warning: Trying to access array offset on null in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 37
PHP Warning: Undefined array key "privacy" in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 38
PHP Warning: Trying to access array offset on null in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 38
PHP Warning: Undefined array key "privacy" in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 39
PHP Warning: Trying to access array offset on null in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 39
PHP Warning: Undefined array key "privacy" in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 40
PHP Warning: Trying to access array offset on null in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 40
PHP Warning: Undefined array key "privacy" in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 41
PHP Warning: Trying to access array offset on null in /includes/modules/content/gdpr/cm_gdpr_acceptance_data.php on line 41
PHP Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /includes/modules/content/gdpr/templates/tpl_cm_gdpr_acceptance_data.php on line 22
PHP Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /includes/modules/content/gdpr/templates/tpl_cm_gdpr_acceptance_data.php on line 22

[burt]

I have only imported customers, no new customers who have agreed to any terms, conditions etc.

customers_gdpr table is of course empty

TY
https://github.com/CE-PhoenixCart/Phoen ... 00be31472c

[frankl]

During checkout, enter comments. Interrupt checkout ( i.e. go back to shopping_cart.php), comment disappears.

[frankl]

In tpl_n_checkout.php, comments do not appear in confirmation emails even though entered correctly (and appearing in order history)

if (!empty($order->info['comments'])) {
echo htmlspecialchars($order->info['comments']) . "\n";
}

I think problem is $_SESSION['comments'] in cart_order_builder.php

In shipping.php there is no longer a comments box, so probably don't need this in process_selection function?

if (!Text::is_empty($_POST['comments'])) {
$_SESSION['comments'] = Text::input($_POST['comments']);
}

[Kofod95]

I think these two constants are unused (and have been so since 1.0.5.1)
//Daniel

[burt]

There are probably hundreds of unused define/const

It's maybe worth deleting them, but that would be a really dull few hours.
I'll save it for a wet and windy sunday at some point in the future.