None Customer Notified messages appearing in order history

[superche]

Hi all using osCommerce Online Merchant v2.3.4.1 CE and what I am seeking to change is when you make a note on an order and deselect the checkbox on Notify Customer: the notes still appear for the customer when they logon and go to My Order History -> View

Seeking to have notes flagged as "Notify Customer:" = No to not show up in My Order History -> View

I know so coding may be required

Thanks Troy

[heatherbell]

checkbox on Notify Customer: the notes still appear for the customer when they logon and go to My Order History -> View

Sorry, I don't remember what appeared on your version but on Phoenix there is also an 'Append Comments' check box which appends your comments to the order and the email or not.

[superche]

I was supplied this information
find in account_history_info:

$statuses_query =

add:

, osh.customer_notified

and with the little if statement you can control the output.

if ($statuses['customer_notified'] == '1'){ xxxxx }

But I am unsure where / how to insert the if statement

Code: Select all

      $statuses_query = tep_db_query("select os.orders_status_name, osh.date_added, osh.comments, osh.customer_notified from " . TABLE_ORDERS_STATUS . " os, " . TABLE_ORDERS_STATUS_HISTORY . " osh where osh.orders_id = '" . (int)$_GET['order_id'] . "' and osh.orders_status_id = os.orders_status_id and os.language_id = '" . (int)$languages_id . "' and os.public_flag = '1' order by osh.date_added");
      while ($statuses = tep_db_fetch_array($statuses_query)) {

[burt]

Does the STATUS of the Order (that shows to the customer) have a PUBLIC status?
Look at your admin > localization > orders status

What should happen...is this:

You update the order into a PRIVATE status if you do not want the comment to show to the customer.

[raiwa]

You update the order into a PRIVATE status if you do not want the comment to show to the customer.

This is not exact the behaviour of public and private order status.
If private, the order dosn't show at all in the account history orders list.
The switcher label says:

Show the order to the customer at this order status level

[burt]

Show the order to the customer at this order status level

I haven't tested it, but thought it worked the way I described.
If not, it should be changed to do so as an order a customer makes must be shown to the customer (in my opinion) whereas an admin note on the order might be private (eg "have reordered XYZ from ABC supplier, this order cannot be fulfilled until it arrives" or whatever)...

[raiwa]

I tested it and it works like the label says: the whole order is hidden, not only the status and comments.

[burt]

I tested it and it works like the label says: the whole order is hidden, not only the status and comments.

Then it needs to be changed in my opinion. GDPR issues here also - you have data about the customer that he/she cannot access...

[raiwa]

Then it needs to be changed in my opinion. GDPR issues here also - you have data about the customer that he/she cannot access...

I agree.
Meanwhile: welcome back!

[burt]

Cheers I'm still randomly online at the moment - I'm still doing a lot of (not very nice) travelling - I am hoping to get back to normality by the end of the summer or so.

-

I *think* it would just be the change to remove "public_flag" in the SQL in two places;

account_history.php
and the page for account_history_info.php

The text in the lang file would need to be amended to make shopowner aware that the order will always be shown, but the Comment(s) (when using comments with non-public status) would not be shown.

Thoughts anyone else? Upsides/downsides?