1.0.9.5 Questions / Comments / Concerns

[raiwa]

EDIT: Got it. Need to install the pi content module first.
This should be included in the update instructions.

THEN:

Install Content Modules & Layout Modules for Contact Us page.

Maybe MODULE_CONTENT_CU_INSTALLED could be added to the update script to avoid the error message in all scenarios/cases.

[raiwa]

In: admin\includes\languages\english\configuration.php line 13 has been added:

Code: Select all

const HEADING_TITLE = 'Configuration';

But it seems not to be used anywhere,
Searched in the main file and all actions.

I believe this is used in Admin area.

I temporary removed it from the language file and went through all Admin -> Configuration pages. No error displayed or logged-> ergo it is not in use?

Just checked for admin/invoice.php: same here and maybe in other pages where it has been added?

I know it doesn't make harm, except the extra job for language maintainers

[burt]

https://github.com/CE-PhoenixCart/Phoen ... 473698e8c0

Follow the code;

https://github.com/CE-PhoenixCart/Phoen ... 357a18eec8

[Pierre_P]

In the admin for store logo we have code

Code: Select all

$logo_query = $GLOBALS['db']->query("SELECT * FROM configuration WHERE configuration_key LIKE '%_LOGO' ORDER BY sort_order");

This '%_LOGO will be problematic for other addons like pdf invoices, pdf packingslip or similar where we defined a LOGO in configuration

[burt]

In the admin for store logo we have code

Code: Select all

$logo_query = $GLOBALS['db']->query("SELECT * FROM configuration WHERE configuration_key LIKE '%_LOGO' ORDER BY sort_order");

This '%_LOGO will be problematic for other addons like pdf invoices, pdf packingslip or similar where we defined a LOGO in configuration

Simple answer: change the addon code "LOGO" const and code.

Other answer: integrate these other addons into the admin/store_logo page.

[frankl]

I don't think we need these in the orders table any more. Nobody would use these, surely?

`cc_type` varchar(20) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_owner` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_number` varchar(32) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_expires` varchar(4) COLLATE utf8_unicode_ci DEFAULT NULL,
or
`orders_date_finished` datetime,

[burt]

I don't think we need these in the orders table any more. Nobody would use these, surely?

`cc_type` varchar(20) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_owner` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_number` varchar(32) COLLATE utf8_unicode_ci DEFAULT NULL,
`cc_expires` varchar(4) COLLATE utf8_unicode_ci DEFAULT NULL,
or
`orders_date_finished` datetime,

This has been brought up previously, but I cannot remember why no action was taken to remove these from the DB,

[raiwa]

Another thing to remove is the cache configuration setting.

[Pierre_P]

I am a bit struggling on a new install and the same issue with updating my existing site to 1.0.9.5

In admin modules content removing all the product_info modules then re adding them does not go to plan, example i will add the buy now button but does not show up on the product page.
I have selected the product_info from the drop down selection to install the modules for the product page.

Even with removing it from pi layout as well this same is happening.
In admin it shows each module for product_info unique sort order and that it is installed.

I have tested this and confirmed on a new install that the same is happening with my updated site.

Anyone can confirm this as well?

[heatherbell]

Anyone can confirm this as well?

Just tested.
For example, Admin>Modules>Content - Install Module.
They show as installed after installation on the admin page but do not show on the product_info page in the store.
However, they work if you uninstall/re-install the π Modular product_info module.
Don't know why. It is unexpected behaviour but think it not something new.